Git Product home page Git Product logo

Comments (10)

abiosoft avatar abiosoft commented on June 2, 2024

What version of ishell are you using ?

from ishell.

abiosoft avatar abiosoft commented on June 2, 2024

The behaviour I'm getting is different. Yes, there is an error message but the application is not getting terminated.

❯ go run example/main.go
Sample Interactive Shell
>>> привет
Error: Unknown rune: 1087
>>> |

from ishell.

pavel-odintsov avatar pavel-odintsov commented on June 2, 2024

This one: fb8c158

from ishell.

pavel-odintsov avatar pavel-odintsov commented on June 2, 2024

Oh, that's awesome! I will rebase to this branch and check! Thank you!

from ishell.

abiosoft avatar abiosoft commented on June 2, 2024

There are differences between v1 and v2 (current master). You will have to do couple of refactors to make your app compatible.

from ishell.

abiosoft avatar abiosoft commented on June 2, 2024

You can re-open this if the issue still exists.

from ishell.

abiosoft avatar abiosoft commented on June 2, 2024

Also, you can put the characters in quotes as a workaround.

❯ go run example/main.go
Sample Interactive Shell
>>> greet "привет"
Hello привет
>>>

from ishell.

fyrchik avatar fyrchik commented on June 2, 2024

Hello! Is there any plan to fix this? I can do this if it doesn't require a lot of refactoring and won't break something.
While commands can be latin-only it is quite common to use unicode in filenames or command arguments.

from ishell.

fyrchik avatar fyrchik commented on June 2, 2024

@abiosoft what do you think about providing custom splitter in config (defaulting to current shlex.Split)?
I can make a PR. Seems like the least invasive option.

from ishell.

fy0 avatar fy0 commented on June 2, 2024

go-shlex caused it:

	cmd := "D:\\codes\\测试\\aaaa.exe asdasd"
	fmt.Println(shlex.Split((cmd)))

from ishell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.