Git Product home page Git Product logo

Comments (14)

slhck avatar slhck commented on May 20, 2024 3

This seems to work! Thank you! 🎉

from web-extension-starter.

slhck avatar slhck commented on May 20, 2024 1

Any updates on this? This would be really crucial to have. Otherwise, awesome project!

from web-extension-starter.

abhijithvijayan avatar abhijithvijayan commented on May 20, 2024 1

Sorry, I was engaged in some projects.

I will try to find if this is possible asap.

Also open for a PR if anyone comes up with the solution.

from web-extension-starter.

slhck avatar slhck commented on May 20, 2024 1

I am not sure this works. I tried the solution suggested in the SO post to no avail.

Looks as follows in Chrome:

image

And here in Firefox:

image

Basically I think that the hot reloading module is interfering here.

from web-extension-starter.

abhijithvijayan avatar abhijithvijayan commented on May 20, 2024 1

@princesust @slhck

See if the fix 23cc204 works

Closing for now.

Feel free to re-open or comment if the issue still persist.

Thanks for reporting the issue

from web-extension-starter.

abhijithvijayan avatar abhijithvijayan commented on May 20, 2024

Let me look into that.

from web-extension-starter.

abhijithvijayan avatar abhijithvijayan commented on May 20, 2024

I am not sure if this is even possible, but I will try to change webpack configuration, hoping to resolve this.

from web-extension-starter.

slhck avatar slhck commented on May 20, 2024

I found that devtool: "source-map", in the WebPack config at least generates the source maps for the browser polyfill, however it creates the following issue:

DevTools failed to parse SourceMap: chrome-extension://biipfmkokfahmjfnnbpegccidgoldhom/js/background.bundle.js.map

from web-extension-starter.

abhijithvijayan avatar abhijithvijayan commented on May 20, 2024

The option `devtool: 'source-map', should work.

Could you see it this error pops up on firefox?

Try: https://stackoverflow.com/questions/44267503/devtools-failed-to-parse-sourcemap

from web-extension-starter.

abhijithvijayan avatar abhijithvijayan commented on May 20, 2024

Also, on a quick look, the solution you suggested should work.

Could you add that line at top and submit a PR?

from web-extension-starter.

abhijithvijayan avatar abhijithvijayan commented on May 20, 2024

I think it is the issue with webextension-polyfill messing with reloader

There is a similar issue here

from web-extension-starter.

abhijithvijayan avatar abhijithvijayan commented on May 20, 2024

@slhck Could you see if everything works with the devtool option enabled and the reloader disabled?

from web-extension-starter.

slhck avatar slhck commented on May 20, 2024

I tested that, and I get the same error. The source code shown is basically the same bundled code, except for the reloader message on top. So the issue is a different one, and probably has to do with webpack itself not providing the source map correctly.

from web-extension-starter.

abhijithvijayan avatar abhijithvijayan commented on May 20, 2024

@slhck @princesust It's an upstream (issue](webpack/webpack#1194)

I have fixed the issue.

Screenshot_20200417_162259

from web-extension-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.