Git Product home page Git Product logo

Comments (1)

aazuspan avatar aazuspan commented on June 5, 2024

This happened because a newly instantiated task will always register a Created event, regardless of its state.

self.event: events.Event | None = events.Created(self)

To handle this, we could:

  1. Add some logic to only register the most recent event for each task (in the example above, ignore the Created event and register the Completed event.)
  2. Redesign the event system to allow tasks to store an event queue.

Option 1 could technically miss a notification in the unlikely case that someone is watching for Created events but not Completed events. Option 2 adds a bit more complexity to cover a relatively minor corner case, and also raises the question of whether we send multiple notifications for a single task or need to make a new system to combine notifications.

I think the path forward may be clearer once I tackle #13.

from taskee.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.