Comments (1)
This happened because a newly instantiated task will always register a Created
event, regardless of its state.
Line 17 in 78f9bfc
To handle this, we could:
- Add some logic to only register the most recent event for each task (in the example above, ignore the
Created
event and register theCompleted
event.) - Redesign the event system to allow tasks to store an event queue.
Option 1 could technically miss a notification in the unlikely case that someone is watching for Created
events but not Completed
events. Option 2 adds a bit more complexity to cover a relatively minor corner case, and also raises the question of whether we send multiple notifications for a single task or need to make a new system to combine notifications.
I think the path forward may be clearer once I tackle #13.
from taskee.
Related Issues (12)
- Native notifications for desktop
- Add notify.run notifier HOT 1
- Add TUI
- Add rich-click
- Report how many tasks remaining
- Allow service accounts and custom credentials HOT 3
- Switch from `getTaskList` to `listOperations`
- Incorrect event time in dashboard
- Handle unknown `Operation.type`
- Report completed task runtime instead of total time
- Crash on image ingestion completed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from taskee.