RPi2 build failed about pvr.freebox HOT 7 CLOSED

Does your toolchain support C++17?

from pvr.freebox.

Does your toolchain support C++17?

Partly, see https://gcc.gnu.org/projects/cxx-status.html#cxx17

I don't think that this is good idea to write an addon which requires fully supported C++17. If you look to all other binary addons, the highest required C++ is 14. And GCC marked C++17 still as experimental:

Important: Because the final ISO C++17 standard is still new, GCC's support is experimental. No attempt will be made to maintain backward compatibility with implementations of C++17 features that do not reflect the final standard

from pvr.freebox.

Well, structured bindings are part of the C++17 final standard and I believe new addons should follow new standards.
Anyway, it's an easy fix and I'll gladly provide support for C++14 :)

from pvr.freebox.

Kodi build env is still c++11. Just saying.

from pvr.freebox.

@mkreisl Should be fixed. Could you please confirm?

from pvr.freebox.

Kodi build env is still c++11. Just saying.

Yes, I know that. Was just doing a quick grep for CMAKE_CXX_STANDARD in my binary addon tree and found a lot of set(CMAKE_CXX_STANDARD_COMPUTED_DEFAULT "14") and was not deeper investigating what that setting does

from pvr.freebox.

Should be fixed. Could you please confirm?

Yes, it is fixed now. Many thanks for your fast response. I really appreciate that

👍

from pvr.freebox.