windows: openssl dependency not working/missing about pvr.freebox HOT 24 CLOSED

Should be fine now :)

from pvr.freebox.

Not yet. Issues with RapidJSON.

from pvr.freebox.

=> d:\jenkins\workspace\binary-addons\kodi-windows-x86_64-matrix\tools\depends\target\binary-addons\pvr.freebox\src\Freebox.h(373): error C2059: syntax error: 'constant'
d:\jenkins\workspace\binary-addons\kodi-windows-x86_64-matrix\tools\depends\target\binary-addons\pvr.freebox\src\Freebox.h(373): error C2238: unexpected token(s) preceding ';'

from pvr.freebox.

Maybe there is some nonsense define for "DELETE" on Windows? Just guessing.

from pvr.freebox.

Highly likely!

from pvr.freebox.

https://stackoverflow.com/a/1271185

from pvr.freebox.

wtf. Windows.

from pvr.freebox.

I suggest to rename the conflicting method.

from pvr.freebox.

Instead of this plain old #undef?
3abf48d

from pvr.freebox.

I would opt for a "safe" method name, yes.

from pvr.freebox.

But ofc your decision.

from pvr.freebox.

sigh...

next one :

D:\jenkins\workspace\binary-addons\kodi-windows-x86_64-Matrix\tools\depends\target\binary-addons\pvr.freebox\src\Freebox.cpp(278): error C2065: '_POSIX_HOST_NAME_MAX': undeclared identifier
D:\jenkins\workspace\binary-addons\kodi-windows-x86_64-Matrix\tools\depends\target\binary-addons\pvr.freebox\src\Freebox.cpp(278): error C2133: 'hostname': unknown size
D:\jenkins\workspace\binary-addons\kodi-windows-x86_64-Matrix\tools\depends\target\binary-addons\pvr.freebox\src\Freebox.cpp(279): error C2065: '_POSIX_HOST_NAME_MAX': undeclared identifier

from pvr.freebox.

This one was predictable. I need to use GetComputerName instead of gethostname.
Or, how about I disable the whole Windows part until I get ahold of a Windows machine?

from pvr.freebox.

But I can manage this through Jenkins, too.
I'm watching the builds go as we speak.

from pvr.freebox.

Or, how about I disable the whole Windows part until I get ahold of a Windows machine?

Nope. Let's get this build done now.

from pvr.freebox.

I'm watching the builds go as we speak.

But you cannot trigger the build. It's me doing this.

from pvr.freebox.

I need to use GetComputerName instead of gethostname.

I don't think so => https://docs.microsoft.com/en-us/windows/desktop/api/winsock/nf-winsock-gethostname

from pvr.freebox.

#ifndef _POSIX_HOST_NAME_MAX
#define _POSIX_HOST_NAME_MAX 64
#endif

?

from pvr.freebox.

The doc says 256 bytes, so I did something similar: 7c53002

from pvr.freebox.

Not sure the platform defs are okay. In other addons we use TARGET_WINDOWS for instance.

Why do you not simply use ifndef instead of "assuming" what is defined I for which platform?

from pvr.freebox.

Done!

from pvr.freebox.

We made it. :-)

Your addon will appear in official Kodi Matrix addon repositoy (for the relevant platforms - Android, macOS, Windows) in the next hour. => http://mirrors.kodi.tv/addons/matrix/

Linux is handled diferently (as you should already know).

from pvr.freebox.

Whenever you want to release and publish a new version, from now on, first bump addon version and changelog, then create a tag for the respective code revision (name does not really matter - I suggest major.minor.micro-kodiversion -> 2.0.1-Matrix). Kodi jenkins will pick up the latest tag per branch automatically, then will build it and publish to addon repository.

from pvr.freebox.

We made it. :-)

Yeah! Thank you so much!

Kodi jenkins will pick up the latest tag per branch automatically, then will build it and publish to addon repository.

No more Android cross-compiling :)

from pvr.freebox.