Add points to each clause of or-patterns about bisect_ppx HOT 5 CLOSED

I suppose we could translate

| (`P1 | `P2), (`P3 | `P4) -> e

to

| `P1, `P3 -> point 1; point 3; e' ()
| `P1, `P4 -> point 1; point 4; e' ()
| `P2, `P3 -> point 2; point 3; e' ()
| `P2, `P4 -> point 2; point 4; e' ()

i.e. count visits to the clauses independently instead of trying to count visits to elements of their cross product.

In any case, this kind of translation would help me to test automata in Markup.ml much more thoroughly.

from bisect_ppx.

I'm a bit confused, your original example doesn't compile; the first branch is a variant and the second a tuple. Did you mean:

match foo with
| `P1 -> e1
| (`P2 | `P3 as x) as y -> e2

from bisect_ppx.

Yes :) I changed the patterns from p1 to ``P1` at the last moment and wasn't careful updating it.

from bisect_ppx.

I think a simpler way of rewriting the original example would be:

match foo with
| `P1 -> Bisect.mark 0; e1
| (`P2 | `P3 as x) -> (match x with `P2 -> Bisect.mark 1 | `P3 -> Bisect.mark 2); e2

This has the advantage of being a simpler recursive map of the Ppat_or pattern

from bisect_ppx.

I think the recursive map is ultimately the same, just the interpretation (what is being constructed as a result of it) is different, but this is a good idea. It doesn't change the "real" case list entered by the user, which keeps instrumented code resistant to bugs in Bisect_ppx, among other things. Thanks.

from bisect_ppx.