<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Out of Bounds about protocollib HOT 2 CLOSED

aadnk commented on August 20, 2024

Out of Bounds

from protocollib.

Comments (2)

aadnk commented on August 20, 2024

Right - PacketContainer yields access to the internal fields in the packet class, not the serialized packet data as seen on the wire. So, if we take the SCOREBOARD_TEAM packet:

public class PacketPlayOutScoreboardTeam extends Packet {
  private String a = "";
  private String b = "";
  private String c = "";
  private String d = "";
  private Collection e = new ArrayList();
  private int f;
  private int g;
// ..
  public void a(PacketDataSerializer paramPacketDataSerializer) {
    this.a = paramPacketDataSerializer.c(16);
    this.f = paramPacketDataSerializer.readByte();

    if ((this.f == 0) || (this.f == 2)) {
      this.b = paramPacketDataSerializer.c(32);
      this.c = paramPacketDataSerializer.c(16);
      this.d = paramPacketDataSerializer.c(16);
      this.g = paramPacketDataSerializer.readByte();
    }

    if ((this.f == 0) || (this.f == 3) || (this.f == 4)) {
      int i = paramPacketDataSerializer.readShort();

      for (int j = 0; j < i; j++)
        this.e.add(paramPacketDataSerializer.c(16));
    }
  }

You have to use integers for action and friendly fire, not bytes. And a collection modifier to write the string collection:

packet.getModifier().<Collection>withType(Collection.class).write(0, null);

from protocollib.

md-5 commented on August 20, 2024

Interesting.
It was working before (as far as I know), so I guess there was some kind of regression that made byte not work.
I'll update the code accordingly tomorrow, thanks for your help.

from protocollib.

Recommend Projects