Comments (4)
@aabounegm Please, configure the Pages settings in GitHub like so:
It is needed for the workflow of publishing the presentation to your GitHub Pages
from cast.
The only protection I applied for now is requiring a PR with one approval before merging. I don't personally like the "dismiss stale approvals" option, but we can vote on it. I will leave this issue open until the CI is all configured so that I require passing status checks as well (if that's desirable), and maybe requiring signed commits (if everyone agrees with Khaled)
@VanishMax done.
from cast.
CI checks are already set up, so you can make them required. As for signing commits, guess we didn't agree on it after all as everyone seems to be pushing unsigned commits.
That said, after enabling the requirement of CI checks, this issue may be closed
from cast.
Ok, and I noticed that #7 is about that anyway, so issue could have been closed since the beginning.
from cast.
Related Issues (20)
- Fix the app icon in the GitHub application HOT 6
- Investigate the Cypress's ability to wait for events HOT 1
- Perform exploratory testing HOT 4
- Configure visual testing
- Create the presentation HOT 5
- Prevent layout shifts on the home page
- Parallelize the CI checks
- Server-side render the listening history
- Playback controls on the episode card are broken
- The app tries to sync history even when the user is not signed in
- Replace the screenshots in the README
- Fix the scrubbing bar pausing playback in Firefox
- Investigate the problems with the drag handle in Firefox
- Increase the testing coverage
- Investigate the flake in the E2E tests HOT 1
- Upload likes and listening history upon connecting to the internet
- Fix the downloaded episodes being incorrectly listed after a refresh
- Clear local likes and history upon signout
- Investigate the "+30s" and "-10s" buttons not always triggering in Firefox HOT 1
- Review the data flow in the library page to avoid overfetching
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cast.