Git Product home page Git Product logo

Comments (4)

vertex-github avatar vertex-github commented on July 26, 2024

I guess I added it 10 years ago :-)

This seems to work ok with our application (based on 1.8.0 source)

public class ParameterParser implements CharParser{

    private final Map<String, List<Integer>> parameterMap;
    int paramIdx = 1;

    public ParameterParser(Map<String, List<Integer>> parameterMap) {
        this.parameterMap = parameterMap;
    }

    @Override
    public boolean canParse(char c, String sql, int idx) {
        // Vertex changes to support ? in SQL in addition to named params
        if( c == '?' ) {
            return true;
        }
        return sql.length() > idx + 1 && c == ':' && Character.isJavaIdentifierStart( sql.charAt(idx + 1) ) && sql.charAt(idx-1) != ':';
    }

    @Override
    public int parse(char c, int idx, StringBuilder parsedSql, String sql, int length) {
        // Vertex changes to support ? in SQL in addition to named params
        if( c == '?' ) {
            String paramName = "p" + paramIdx;
            List<Integer> indices = parameterMap.computeIfAbsent( paramName, k -> new ArrayList<>() );
            indices.add(paramIdx++);
        }
        else {
            int startIdx = idx;
            idx += 1;
            while( idx + 1 < length && Character.isJavaIdentifierPart( sql.charAt( idx + 1 ) ) )
            {
                idx += 1;
            }
            String name = sql.substring(startIdx + 1, idx + 1);
            List<Integer> indices = parameterMap.computeIfAbsent( name, k -> new ArrayList<>() );
            indices.add(paramIdx++);
        }

        parsedSql.append("?");

        return idx;
    }
}

from sql2o.

aaberg avatar aaberg commented on July 26, 2024

Hi,

I checked the code for Sql2o version 1.5.1, and the code for the createQueryWithParams method looks more or less the same. So, I don't think this has been officially supported. But as you say, it's been a while since the library was updated, so I might be mistaken.

The createQueryWithParams method expects parameters to be named :p1, :p2, and so on, which is kind of silly. I would prefer if the variant you are using also works since ? is the official character for parameters in Java. If it isn't too much work to fix, I might just do that. I'll check it out and let you know what I find out.

from sql2o.

vertex-github avatar vertex-github commented on July 26, 2024

The changes above just parse out the ? and make fake param names.

from sql2o.

aaberg avatar aaberg commented on July 26, 2024

You posted your comment a minute before me there 😄. Thank you for posting that, I'll check it out.

from sql2o.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.