es6-port about react-scaffolder HOT 21 OPEN

Sure, fork this repo, create your own branch and start working. Please use contribution guidelines provided.

from react-scaffolder.

Is the issue still open, as I am willing to do it

from react-scaffolder.

Can I do it?

from react-scaffolder.

@dhruvdutt just to clarify things, are you still working on this issue.

from react-scaffolder.

Sorry for the delay.
Most of the things seem alright. I'm still learning ES6. Is there anything to do except transforming normal functions into arrow functions?

from react-scaffolder.

It's fine, take your time, we need quality over quantity. Basically you can use arrow functions as a short hand syntax for normal functions, but you need to be careful about the context since arrow functions takes up the parent context. Also you can features like default arguments in ES6 within functions.

from react-scaffolder.

Also worth mentioning is that ES6 has a new class syntax that's way nicer. Import and export have changed as well, you can do, for example, export class MyClass instead of modules.export = {}. Read more about it here.

from react-scaffolder.

@rafaelklaessen You can take this up if you wish.
I have been really busy lately with academics work.

from react-scaffolder.

Okay, I will. I've never worked with React though, so it will take a while.

from react-scaffolder.

@rajikaimal I've created a pull request with the ES6 port.

from react-scaffolder.

I started a review on PR #17

from react-scaffolder.

I'm reviewing too. 😸

from react-scaffolder.

So, is my ES6 version going to be used or...?

from react-scaffolder.

We'll start improvements based on the work that you've done on this issue.

from react-scaffolder.

Okay

from react-scaffolder.

Hi I am interested on this. Can I start working on it ? if it's not completed.

from react-scaffolder.

Looking at the code that I wrote back then there's plenty of room for improvement.
It's now kinda-partially ES6

from react-scaffolder.

Is it on a particular branch ? Or is it already merged ? I can continue with the things you have done.

from react-scaffolder.

It's on the es6 branch.
Do note that there's 41 new commits in master that need to be merged as well (or you can create a new branch and just redo it all)

from react-scaffolder.

Okay thanks for the heads up. I will start working on them.

from react-scaffolder.

Hi, yes you can give a try.

from react-scaffolder.