Comments (6)
@hughkolias I will look into this in the evening, thanks!
from griddler-ses.
Thanks @ccallebs - let me know if there is anything on our end that could help.
from griddler-ses.
@ccallebs - as per thoughtbot/griddler#304, if we can force encoding on the returned body it should solve the issue.
I can submit a PR for it if you'd like?
Long story short is that the body that's being presented to Griddler to parse is encoded in US-ASCII (eg ASCII-8BIT).
I believe the underlying issue is related to the SES adapter decoding the Base64 encoded payload. decode64 always returns a US-ASCII encoded string (since it has no idea what the original encoding of the string was). The encoding has to be forced to UTF-8 after it is decoded.
You can test this yourself:
require 'base64'
str = "foobar"
str.encoding #Encoding:UTF-8
b64str = Base64.encode64(str)
b64str.encoding #Encoding:US-ASCII
Base64.decode64(b64str).encoding #Encoding:US-ASCII
Also, I just want to make sure you're ok with having posted that email body publicly. There appear to be a few email addresses just in the JSON payload. Not sure what content could be in the message body itself.
from griddler-ses.
@hughkolias If you'd like to submit a PR that would be great, please just make sure to write an accompanying spec that reproduces the bug. Also, please base the changes off of my fork for the time being.
from griddler-ses.
Thanks @ccallebs - Let me know your thoughts: ccallebs#3
from griddler-ses.
addressed via ccallebs#3
from griddler-ses.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from griddler-ses.