Comments (23)
I would prefer toFactory(). I think Guice is also adding toConstructor() in
Guice
2.0, so that would be more consistent.
http://code.google.com/p/google-guice/issues/detail?id=231
Original comment by [email protected]
on 23 Dec 2008 at 8:14
from google-gin.
Currently waiting for Guice issue
http://code.google.com/p/google-guice/issues/detail?id=131 to be resolved, will
proceed with this when they have made up their mind.
Original comment by aragos
on 31 Dec 2008 at 9:23
- Changed state: Blocking
- Added labels: Priority-Low
- Removed labels: Priority-Medium
from google-gin.
Original comment by aragos
on 31 Dec 2008 at 9:23
- Changed state: Blocked
from google-gin.
Guice issue 131 has been resolved. Our implementation permits the standard
@Inject annotation on the
constructor. It uses a one-time-use child injector to create the object.
Original comment by limpbizkit
on 31 Dec 2008 at 11:34
from google-gin.
Ok, I must have overlooked that last message. The resolution doesn't solve my
problem here though: Was there any later agreement on the API changes? I'd
like to
keep our EDSL in sync with Guice's.
The other question that I have is about the structure of the factories: Guice's
implementation currently enforces one-to-one mappings for factory<->injectee,
plus
one-to-one mappings for constructors<->factory methods, if I understand the code
correctly. Will that stay this way or are there any plans to allow those
features?
I'd really like to see at least the one-to-many mapping for factories and
injectees
and am not entirely clear on what the issues are that prevent it.
Original comment by aragos
on 1 Jan 2009 at 11:32
- Changed state: Accepted
from google-gin.
The current allows each factory to produce only one type. It uses the standard
@Inject annotation on the
constructor. One tricky detail is that our implementation uses child injectors
— we do this to support AOP, but it
also allows injecting providers for the parameters, and injecting parameters
indirectly.
Original comment by limpbizkit
on 2 Jan 2009 at 2:38
from google-gin.
The main problem currently blocking this issue is that Guice doesn't support
assistedInject in its EDSL or SPI. I can work around that, but things would be
a lot
cleaner and consistent if we could just use assistedInject as a Guice feature.
Original comment by aragos
on 26 Jan 2009 at 4:43
from google-gin.
Any progress with this issue?
Original comment by [email protected]
on 15 Jun 2009 at 11:29
from google-gin.
Yes, I have submitted a change to Guice Assisted for review that would (a)
extend the
capabilities of Assisted Inject and (b) make integration into Gin much easier.
That
change still needs an ok from the Guice guys though.
See also: http://code.google.com/p/google-guice/issues/detail?id=346 and
http://codereview.appspot.com/25084
Original comment by aragos
on 15 Jun 2009 at 2:56
from google-gin.
Guice seems to be sticking with assistedinject for now.
Can GIN use that too?
Original comment by [email protected]
on 19 Jun 2009 at 2:29
from google-gin.
Gin cannot use the current assisted inject or easily offer anything similar.
The new
proposed API for Assisted Inject would be easier support, even though it is
never
integrated with Guice.
Original comment by aragos
on 25 Jun 2009 at 10:57
from google-gin.
Any news in this issue?
Original comment by [email protected]
on 18 Aug 2009 at 10:17
from google-gin.
The new assisted inject version is going to be released soon (this month) and
then I
can finally look into porting it to Gin. No estimates on when that's finished
though.
Original comment by aragos
on 19 Aug 2009 at 12:16
from google-gin.
Original comment by aragos
on 1 Dec 2009 at 1:49
from google-gin.
Is there any news about this issue?
Original comment by [email protected]
on 29 Jan 2010 at 6:05
from google-gin.
Issue 68 is no more an issue.
Original comment by [email protected]
on 7 Mar 2010 at 7:48
from google-gin.
I'm working on this but it will take a bit since I'm pretty busy with my regular
work. I'll let you know once I have a patch ready that needs reviewing.
Original comment by aragos
on 8 Mar 2010 at 8:19
- Changed state: Started
from google-gin.
After a ridiculously long time this patch is finally finished and ready for
review!
Please take a look here, leave your comments and let me know what you think:
http://codereview.appspot.com/974041
Once the review has finished, I'll submit the patch.
Original comment by aragos
on 22 Apr 2010 at 2:03
- Changed state: Review
from google-gin.
Excellent! I'm looking forward to using this in gwt-platform!
Original comment by philippe.beaudoin
on 22 Apr 2010 at 3:42
from google-gin.
haii
Original comment by [email protected]
on 27 Apr 2010 at 12:57
from google-gin.
Committed in r138. :)
Original comment by aragos
on 17 May 2010 at 5:34
- Changed state: Fixed
from google-gin.
Hello,
I was wondering How I'm suppose to use this. Do I checkout and build latest
Guice /
Gin / AssistedInject?
Thanks, Jee.
Original comment by [email protected]
on 21 May 2010 at 1:14
from google-gin.
Yep, pretty much. I'll release a new version of Gin once Guice 2.1 has been
released
(no idea when that'll happen).
Original comment by aragos
on 21 May 2010 at 2:51
from google-gin.
Related Issues (20)
- Warning for missing annotation source code HOT 3
- Inject order should be constructors then fields then method HOT 7
- Unexpected error while using a private inner module: "Unable to inject an instance of XXX because it is a private class."
- GinFactoryModuleBuilder does not respect @Singleton HOT 3
- [Patch] Use own ClassLoader over SystemClassLoader to make Hosted Mode working HOT 3
- Views/widgets as singletons are present in memory and keep playing even after changing the view.
- Should have GIN error rather than gwt compiler error in package-private+generics corner case HOT 1
- Gin 2.1 not published in maven central HOT 2
- Gin 2.1 and Java6 results in: Unsupported major.minor version 51.0 Error HOT 6
- Allow double bound for identical definition HOT 2
- Publish GIN 2.1.1 to Maven Repository HOT 1
- Javadoc link broken in project home page HOT 1
- Using GinMapBinder with annotations produces Double-Bound exception HOT 1
- Gin trunk is incompatible to GWT trunk because of recent Guava 15 refactoring in GWT HOT 5
- java.lang.NoClassDefFoundError: sun/security/timestamp/Timestamper HOT 1
- Can't run with Google Web Toolkit 2.6 RC1 HOT 7
- GinModuleAdapter sometimes gives errors with singleton binding of concrete classes HOT 1
- GIN does not respect injection order when subclassing HOT 1
- Reduce code bloat for multiple instances of the same PrivateGinModule
- Move to Github HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from google-gin.