Add support for assisted inject about google-gin HOT 23 CLOSED

I would prefer toFactory(). I think Guice is also adding toConstructor() in 
Guice
2.0, so that would be more consistent.
http://code.google.com/p/google-guice/issues/detail?id=231

Currently waiting for Guice issue
http://code.google.com/p/google-guice/issues/detail?id=131 to be resolved, will
proceed with this when they have made up their mind.

Guice issue 131 has been resolved. Our implementation permits the standard 
@Inject annotation on the 
constructor. It uses a one-time-use child injector to create the object.

Ok, I must have overlooked that last message.  The resolution doesn't solve my
problem here though:  Was there any later agreement on the API changes?  I'd 
like to
keep our EDSL in sync with Guice's.

The other question that I have is about the structure of the factories:  Guice's
implementation currently enforces one-to-one mappings for factory<->injectee, 
plus
one-to-one mappings for constructors<->factory methods, if I understand the code
correctly.  Will that stay this way or are there any plans to allow those 
features? 
I'd really like to see at least the one-to-many mapping for factories and 
injectees
and am not entirely clear on what the issues are that prevent it.

The current allows each factory to produce only one type. It uses the standard 
@Inject annotation on the 
constructor. One tricky detail is that our implementation uses child injectors 
— we do this to support AOP, but it 
also allows injecting providers for the parameters, and injecting parameters 
indirectly.

The main problem currently blocking this issue is that Guice doesn't support
assistedInject in its EDSL or SPI.  I can work around that, but things would be 
a lot
cleaner and consistent if we could just use assistedInject as a Guice feature.

Any progress with this issue?

Yes, I have submitted a change to Guice Assisted for review that would (a) 
extend the
capabilities of Assisted Inject and (b) make integration into Gin much easier. 
That
change still needs an ok from the Guice guys though.

See also: http://code.google.com/p/google-guice/issues/detail?id=346 and
http://codereview.appspot.com/25084

Guice seems to be sticking with assistedinject for now.

Can GIN use that too?

Gin cannot use the current assisted inject or easily offer anything similar. 
The new
proposed API for Assisted Inject would be easier support, even though it is 
never
integrated with Guice.

Any news in this issue?

The new assisted inject version is going to be released soon (this month) and 
then I
can finally look into porting it to Gin. No estimates on when that's finished 
though.

Is there any news about this issue?

Issue 68 is no more an issue.

I'm working on this but it will take a bit since I'm pretty busy with my regular
work. I'll let you know once I have a patch ready that needs reviewing.

After a ridiculously long time this patch is finally finished and ready for 
review!
Please take a look here, leave your comments and let me know what you think:
http://codereview.appspot.com/974041

Once the review has finished, I'll submit the patch.

Excellent! I'm looking forward to using this in gwt-platform!

haii

Committed in r138. :)

Hello,

I was wondering How I'm suppose to use this. Do I checkout and build latest 
Guice / 
Gin / AssistedInject?

Thanks, Jee.

Yep, pretty much. I'll release a new version of Gin once Guice 2.1 has been 
released
(no idea when that'll happen).