Git Product home page Git Product logo

Comments (3)

EmeraldSnorlax avatar EmeraldSnorlax commented on August 22, 2024 1

Not doing so strongly goes against conventions and will make it more difficult for others that are working against the API. Besides from the looks of it, it seems that error handling could deal with a refactor anyway...

Just returning the status code is fine, the status code contains the semantics of it anyway. Text should only really be provided if its a client error and the client has made a mistake (eg 403: You don't have permission to view /foo)

for server errors, just sending back a vague 500 class error is the norm, and is actually preferred, in order to not accidentally send across sensitive data.

from fs-over-http.

5HT2 avatar 5HT2 commented on August 22, 2024 1

Fixed in 44cb687

from fs-over-http.

5HT2 avatar 5HT2 commented on August 22, 2024

I don't know how I feel about fixing this other than for "muh proper webdev REST model". I've added new notes in the README but I'm still undecided on actually printing any visible response other than a status code if there's an error.

from fs-over-http.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.