Comments (3)
Not doing so strongly goes against conventions and will make it more difficult for others that are working against the API. Besides from the looks of it, it seems that error handling could deal with a refactor anyway...
Just returning the status code is fine, the status code contains the semantics of it anyway. Text should only really be provided if its a client error and the client has made a mistake (eg 403: You don't have permission to view /foo
)
for server errors, just sending back a vague 500 class error is the norm, and is actually preferred, in order to not accidentally send across sensitive data.
from fs-over-http.
Fixed in 44cb687
from fs-over-http.
I don't know how I feel about fixing this other than for "muh proper webdev REST model". I've added new notes in the README but I'm still undecided on actually printing any visible response other than a status code if there's an error.
from fs-over-http.
Related Issues (7)
- [Issue moved] Switch to a real DB HOT 2
- Switch to GH Containers
- OOM killer kills it for serving large files
- Send dir listing as a stream or single request
- `400 Missing 'file' or 'dir' or 'content' form` but the `file` key is present. HOT 11
- FOH logs a 404 after something is done being uploaded by forms HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fs-over-http.