Fix cell heights in iOS 13 about ios HOT 2 CLOSED

Making this a UIViewController subclass that implements the table view controller delegates fiixed this, just gotta wrap up the work on it.

It really looks like this was something deep in the default UITableViewController setting automatic cell heights, and that was conflicting with the autolayout we were doing in the cells. IMHO, you have to pick one or the other and stick with it 100% in table views and even after removing all the auto dimension stuff I was still getting weird behavior.

from ios.

Actually all wrong!

It seems like this is tied to our custom nav header for this view (explains why the More Issues page never had this problem too), if I set tableView.contentInsetAdjustmentBehavior = .automatic then this behavior goes away, but the headers are double-inset, like below:

Setting this back to tableView.contentInsetAdjustmentBehavior = .never makes the headers appear at the right location, but when scrolling the cells get all weird again.

I might check into adjusting how we add this view as a subview of IssueContainer - it's possible that changing the embed behavior will make the auto insets just work.

from ios.