plugin .library should include the file automatically about primus HOT 7 CLOSED

If I would require.resolve that in the primus library your files would end up missing as it would search the directory of the primus module not the directory of your primus plugin.

I can just check if the library is an array and do a simple:

if (Array.isArray(plugin.library)) library += plugin.library.map(function (path) { 
  return fs.readFileSync(path, 'utf-8');
}).join('\n');

I don't have a problem with that at all :)

from primus.

At least, if that is what you want ;)

from primus.

I see. glob, like in grunt, would be useful, since it translates to real paths to the files, since you can specify the src, so it would know where to start searching. indeed, require.resolve isn't the way to go, and the problem is more dificult to solve than it sounds. unless the directory (before readFileSync) is forcefully appended with the required plugin file path, but that would need a change in the use function to accept options I guess.

from primus.

I honestly don't the big problem here, what's the problem with doing a require.resolve in the plugin?

from primus.

well, relative paths won't work, unless it's __dirname + 'library.js', the require will know where to look for them. mostly because of that. relative paths like ./file.js or ../../file.js won't work unless you use the current plugin file path (that is unknown to primus, since you use primus.use with an already require'd module).

from primus.

Why would need relative paths? What's wrong with the __dirname & resolve approach?

from primus.

nothing, it just need to be stated explicity in the readme that the library paths (that will be concat'ed) need to be absolute instead of relative. that would be the only catch, else, everything is fine

from primus.