Requirejs and Client code don't play nice about primus HOT 6 CLOSED

Hey,

I'm definitely interested in having requirejs support. There's already some module bootstapping code that should make importing easier but I can see that the require statements become an issue for requirejs support. There are some issues how ever.

• It shouldn't break Node.js support as the primus.js is also ran on the server.
• It shouldn't break browserify support.
• There are require statements in the client code from the Transformers as well. There isn't really a nice way to get around those I imagine.
• Engine.IO is build with componentjs which uses it's own require code so that will probably clash with requirejs as well.

from primus.

See docpad/docpad-plugin-livereload#5 (comment) for how DocPad users are getting over this

from primus.

@balupton I've got Primus in my require.js shim config. But the issue is that for some reason, the try/catch is throwing an error that isn't actually being caught. I checked the thread you linked to, but I'm not sure I see the answer, could you elaborate?

from primus.

By loading the Primus stuff before the require.js library?

from primus.

Could 06eae1a be a fix for this?

from primus.

I'm going to close this with the assumption that the commit referenced above fixed it. If this is not the case or if there happens to be a regression, feel free to re-open or give me a heads up about it.

from primus.