Comments (8)
Now eslint is configured more strictly. Therefore, I will list some controversial points that had to be made.
- About different versions of
json-utils
. I think we can leave only last one now? I deleted the rest. - In
index.js
I commented:
if (typeof VERSION !== 'undefined') {
console.log(`3DStreet Version: ${VERSION}`);
}
from 3dstreet.
Yes keep only json-utils_1.1.js that's the one used, you can remove the other versions.
Keep the 3 lines, just add /* global VERSION */
on top. webpack is setting this VERSION variable.
from 3dstreet.
Yes keep only json-utils_1.1.js that's the one used, you can remove the other versions.
Keep the 3 lines, just add
/* global VERSION */
on top. webpack is setting this VERSION variable.
Ok, thanks. I have problems running the command in my localhost: npm run lint
. I'm looking for the reason, but perhaps anyone knows what this could be related with?
No files matching the pattern "'src/**/*.js'" were found.
Please check for typing mistakes in the pattern.
Although I run it from 3DStreet root dir.
from 3dstreet.
That's weird. Which OS are you using? Windows?
Can you try to change the lint command to eslint --ext .js,.jsx src
to see if that helps?
from 3dstreet.
That's weird. Which OS are you using? Windows? Can you try to change the lint command to
eslint --ext .js,.jsx src
to see if that helps?
Yes, windows. The problem went away when I removed the quotes here: 'src/**/*.js'
Or if escape double quotes, it will work on unix/windows, as chatGPT says:
"lint": "eslint \"src/**/*.js\" \"src/**/*.jsx\"",
from 3dstreet.
Ok, let's change the command to eslint --ext .js,.jsx src
there is no quotes in it.
from 3dstreet.
Its is done: #530
from 3dstreet.
closed by #530
from 3dstreet.
Related Issues (20)
- create 20 metadata entries in cardsData.js for models
- fix / update variant launch ar key HOT 1
- Last Login in users table doesn't seem to be accurate
- google.maps.Marker is deprecated
- 'DOMSubtreeModified' mutation event is deprecated (in assets.js)
- add undo for geospatial
- Error in in Right Panel after making New scene HOT 1
- Record canvas in posthog HOT 2
- flickering menu returns
- wrong camera angle when switch to Cross Section View after zooming in on Plan View HOT 1
- editing primitive geometry properties does not work HOT 2
- undo error when using hand tool instead of pointer tool HOT 1
- ability to select crosswalks and other stencils HOT 1
- posthog events for payment modal HOT 1
- sometimes 3dtiles do not load HOT 1
- additional undo commands to support autosave
- cleanup left-hand properties panel
- Camera button HOT 1
- regression - 3dtiles error in ortho mode HOT 2
- add image layer HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 3dstreet.