Comments (15)
This is an issue.
Basically every button has a context, providing information about the App it's on.
Apps inside Apps don't quite do this correctly, and it would take quite a bit of work to finish this, which is why we haven't found time to do it yet.
from 2sxc.
ToSic.Sxc.Dnn.17.04.01_Install.zip
@jeremy-farrance and @6TELOIV I believe I fixed it, but it was way more complex than you may imagine.
As such, I need your help to:
- verify it works
- verify nothing else in typical edit etc. broke
I've included a temporary 17.04.01 above, pls test and confirm. thanks!
from 2sxc.
Not sure if it helps, I'm talking about clicking this button inside inner-content apps:
from 2sxc.
Makes sense, and I figured about as much. I've also noticed some other oddities with them (moving items up and down in a list with toolbar buttons doesn't work, opening the list manager doesn't work). Wish I had more time to dive in and try to figure it out myself, haha!
from 2sxc.
Glad I found this, was about to post the same. I can confirm it is still a problem in the latest, v17.03.00 (on DNN v9.13.02).
If it helps; in our case we were in inner-content in the Accordion App (4.3.1) and adding Basic Content from the Content App (16.0.0).
We also noticed additional, probably related issues. If they are not related, please let me know and I can create new/separate issues. Also, there might be additional issues, I stopped after getting details and verifying the following 3:
- Toolbar buttons for Move Up and Move Down do not work
- Toolbar button for Remote Item (screenclip below) does not work (but adding an empty block does work)
- Toolbar button for Sort/Manage List immediately throw a bad request 400 error with, "Detail: Object reference not set..." (console error below)
from 2sxc.
Question: this project is scheduled to go live Apr 2nd. Ever since we upgraded to v16.01 and then v16.07 LTS we have not been able to manage any inner-content beyond edit/save. We have the Accordion App in use on this site fairly extensively (the View has 43 instances across 30+ pages). Is there any chance this will be fixed in March?
from 2sxc.
TBH I believe this never worked before - if it did, I would appreciate knowing which fairly recent version - because then we would only have to re-fix. ATM I think we need to actually implement this.
I know we had started on this once about 2 years ago, but I thought we never completed it.
Could be that we did though, and in that case we only need to re-apply it.
Any chance you could find a sponsor? I think we would need ca. 1-1.5 days to make this work.
from 2sxc.
Okay, so I just installed a clean, new DNN instance using v9.13.03, then installed 2sxc v14.07.04 LTS.
Then tried to install an app; Accordion 4.3.1 would NOT install, no errors, just "installed/success" then it wasn't there. Checked under the hood, the expected folder /Portals/0/2sxc/Accordion (or /Accordion4?) was not there.
But, Accordion 4.3.0 installed fine (not sure why 4.3.1 wouldn't install and did not show an error)
So, as expected, these things were working. See screen shot below. I was able to add Accordion sections with inner content and able to move them up/down, remove, add existing, and replace. I still have this instance available locally if there is anything specific you want me to test further that might help.
from 2sxc.
Okay, so first I upgraded my testing site from 2sxc 14.07.04 to 17.01.07. Then installed CodeDom 3.6. Tested and as expected, toolbar things were NOT working.
Downloaded and Installed v17.04.01 and ... FIXED. This is great, I hope you do the release soon, thank you!!
from 2sxc.
@jeremy-farrance & @6TELOIV pls also test other normal toolbar-to-dialog features, to verify that nothing new broke.
from 2sxc.
Ok, tested every toolbar button, all seems good. Is there anything else you can think of that might be related? Since I've got this instance ready to go, easy to test or change stuff if you think it might help or prevent.
What other apps use inner content? Would it be worth testing a different one? Doesn't seem likely it to me, but you would know better.
from 2sxc.
@jeremy-farrance I'm not too concerned with inner content working, since you and I tested it.
I'm more concerned if it could have some side-effects to anything else, live normal edit (not in inner content), etc. or replace-item (not inner content).
I have a good feeling, but would appreciate some testing. ;)
from 2sxc.
Okay, I switched and inserted a few different content types from the Content App on to the page and tested through all the default toolbar buttons. Everything worked as expected. I did notice, in the standard/default toolbar, that in the 3rd group, the edit View Settings button was missing (only edit template, edit items of the data type, and edit fields of this content type were there. I think I am used to edit View settings being in there, but maybe not? Or maybe its not because I am in the Content module and not App? But anyhow, played around for a bit and all seems great and works as expected!
from 2sxc.
awesome, thanks!
Feel free to use this release, we plan to make another release end of next week ca. March 20.
from 2sxc.
Thank you! As I mentioned in #3317 I won't be able to test for a little while, but I'll keep it on my to-do list!
from 2sxc.
Related Issues (20)
- Feat: ITypedItem.Gps(...)
- Experimental: AppCode - try to support razor base class with typed model
- Feat: In Data-Admin, show if a link is number based or the real string
- Experimental: Typed App with Settings/Resources Typed (AppCode) HOT 1
- Bug: Dropdown fields sometimes show wrong title
- C# CmsView object - provide Resources
- Code: Create CodeCustomize Service to provide type App/View objects.
- QuickE deletes non-selected content block when using inner content blocks HOT 3
- Bug: Edit UI: DateTime settings don's show the time-toggle after reloading
- Feat: Implement $select odata convention on REST APIs
- Bug: Page Picker in UI fails in 17.03
- Bug: Edit UI - date picker off by Time Zone Offset
- Feat: Improve Roslyn Build Performance in Dnn
- Feat: ITypedItem.Img(...) as addition to ITypedItem.Picture(...)
- Bug: Calling a Query using JS is missing the Id field in 17.03.00
- Trojan: Wacatac.B!ml HOT 10
- Bug: Old Token Templates fail on Toolbar and Presentation
- Feat: Improve Image Resize info on Toolbar tooltip
- [Feature Request] Improve item version history with username HOT 2
- [Feature Request] Show deleted items in history
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2sxc.