Rubik's Cube is spelt incorrectly in English on the title screen about techmino HOT 12 CLOSED

Try a pull request?

from techmino.

I have no idea what that is :/

from techmino.

not substantive supplement, no need to use pull request i think

from techmino.

what is a pull request on github

from techmino.

It is important to know who made the contribution.

from techmino.

Is issue not enough?

from techmino.

With a commit you know who made the contribution after cloning the repository locally.

from techmino.

Also pull requests are for collaboration, not only for big changes.

from techmino.

So whatever, it's up to himself to be a collaborator or not

from techmino.

Well...

Here's what's commonly done in most other repos:

• If you know how to fix a problem, change it, do a pull request. Even if it's a one-letter change.
• If you don't know how to fix a problem, or if you don't know how git(hub) works, or if you have doubt about the fix, open an issue, and people will discuss about, and come up with a fix for it.

Apparently MrZ was like: so it's just a one-letter change? I'll change it in the next commit, you don't need to pull request. Technically it's legal, but it doesn't seem to be common practice.

from techmino.

Pull request is not only for "big" features.

from techmino.

So whatever, it's up to himself to be a collaborator or not

Yes, you are right.

from techmino.