Change messageReceived signature? about arduino-mqtt HOT 8 CLOSED

Actually this would also fix a serious bug as creating a String from the payload using String(payload) allocates another buffer with the exact copy.

from arduino-mqtt.

Is not very user friendly, but can be better!
You can add the sign if MQTTMessage in the readme or as comment in the examples?

from arduino-mqtt.

What is not very user friendly? The current implementation or this proposed change?
Sorry, I read your answer now various times but still don't get it... 😄

This would be a breaking change and result in releasing a v2.

from arduino-mqtt.

Sorry for the language ;)
I'm saying that a lot's of arduino users may not be friendly with data structures and usually in the libraries are avoided, but if you don't want to hack the MQTTClient.h code I agree that use the MQTTMessage in the callback is the best way.
I suggest that in the readme we should add the structure description, like:

typedef struct {
    char * topic;
    char * payload;
    unsigned int length;
    boolean retained;
} MQTTMessage;

or in the examples as a comment.

from arduino-mqtt.

Thanks for the clarifications.
I'm not yet fully convinced by my own idea, so I have to sleep on it again some time. ;)

I'll keep you updated.

from arduino-mqtt.

Note to myself: To support multiple clients at the same time the signature could even be updated to something like this:

void messageReceived(MQTTMessage msg, MQTTClient* client) {
  Serial.print("incoming: ");
  Serial.print(msg.topic());
  Serial.print(" - ");
  Serial.print(msg.payload());
  Serial.println();
}

from arduino-mqtt.

Regarding #38 (comment), in general it would be nice to avoid pointers in the call back, as from my understanding most Arduino users aren't exposed to them.

from arduino-mqtt.

Has been simplified in #59.

from arduino-mqtt.