Git Product home page Git Product logo

Comments (11)

abdatta avatar abdatta commented on May 14, 2024 5

Maybe we can make it into an installable PWA instead. Desktops are supporting PWAs as well now irrespective of OS (as long as you have chrome). Would probably be easier.

from jspaint.

1j01 avatar 1j01 commented on May 14, 2024 5

@abdatta Yeah that's definitely more of a priority. So far jspaint is installable (as a PWA), but doesn't work offline (no service worker). See #109

from jspaint.

devxpy avatar devxpy commented on May 14, 2024 2

+1 This would be really nice to have.
JS paint is definitely better than the over cluttered desktop apps we have on linux.

Its so simple that 5 year old can use it, and I mean literally, because I am using Paint since i was 5.

Having this as the default desktop image editing tool would be sick.

Thanks for making this project, really appreciate it!

from jspaint.

1j01 avatar 1j01 commented on May 14, 2024 2

I've made a lot of progress on this, now merged into master.

Things that are done:

  • Lots and lots of boilerplate, like handling clicking links to open your default browser
  • File > Set as Wallpaper (could use testing on different operating systems)
  • Clipboard support
  • Opening and saving files, including saving over opened files with Save (vs Save As), and saving as PNG, JPEG, or WebP
  • I generate a .reg file that you can use to set up a right click > Edit option for images in Windows Explorer - but this isn't exposed to the UI currently; you just have to find it and double click on it - and there's no undo FYI

I'm not interested in pursuing this, but if someone wants to help, the next step is to find someone with experience releasing electron apps (specifically with electron forge) to help set up autoupdating.


To try out the desktop app so far, see Development Setup on the readme.

from jspaint.

1j01 avatar 1j01 commented on May 14, 2024 1

The electron app is essentially done, just needs autoupdating set up and to be published (plus a few fixes — I may have broken file saving in recent changes?)

from jspaint.

1j01 avatar 1j01 commented on May 14, 2024

Yes, this is something I want to do. You can already run it with nw.js (clone repo, npm i, npm start) but I don't think it has any benefits, i.e. I haven't yet implemented proper clipboard support or a dialogue when closing or subwindows that can actually go outside the main window or anything. Also, jspaint tries to be always saved, and if you close a tab you can reopen it to get the session back, but on desktop this will need some other kind of handling.

from jspaint.

HKalbasi avatar HKalbasi commented on May 14, 2024

@1j01 It is not installable (At least on chromium desktop). It need a service worker (even an empty one). #144 will solve it.

from jspaint.

o0101 avatar o0101 commented on May 14, 2024

I think this problem is solved.

https://github.com/c9fe/jspaint.exe

from jspaint.

HKalbasi avatar HKalbasi commented on May 14, 2024

I'm afraid of releasing an app that can't update. (Similar to why I haven't made the PWA offline-capable)

Service worker can be configured to first look at online version and only fallback to cached when there is no connection.

from jspaint.

1j01 avatar 1j01 commented on May 14, 2024

I just pushed a bunch of improvements to the Electron app to master if anyone wants to give it a test:

  • Merged #315
  • Improved macOS integration:
    • The titlebar shows an icon representing the open file, which can be dragged into other apps, and it becomes grayed/faded to indicate when there are unsaved changes.
    • Handled dragging files onto the dock icon to open. (This only works in the packaged version, using a generated Info.plist file that tells macOS what file types it accepts. All files, for now.)
    • Created a new ICNS file with higher resolutions.
  • Added a command-line interface, with --help and --version flags. Other than that it just takes a file path.
  • App is now single-instance; second instances exit and open a file in the first instance.
    • Dealt with insane electron bugs.
  • Packaging:
    • Configured packaging for macOS (zip), Windows (installer), and Linux (deb, rpm).
      • Icons, descriptions, categories, executable names, even an animated GIF for the Windows installer!
    • Configured publishing to GitHub Releases.
    • Handled Squirrel.Windows events.
  • Fixed error re-registering events when closing and re-opening the window on macOS.
  • Fixed bringing the window to front on macOS, and then fixed it on Windows by conditionally using old way.
    • Everything in Electron is harder than they let on in the docs, if you want to get it right. It's like a fractal of footguns.
  • Fixed unnecessary save prompts when closing the app.
  • Fixed "Open" links in File > Manage Storage dialog. Mostly.
    • It still shows a confusing inapplicable message if you have unsaved changes.
  • Fixed File > Exit.
  • Allowed write access to dropped files.
  • Reworded dialog messages to avoid terminology like "your browser"

I might publish a prerelease version soon to make testing easier.

from jspaint.

1j01 avatar 1j01 commented on May 14, 2024

I published Windows/Mac/Linux builds for testing: https://github.com/1j01/jspaint/releases/tag/v1.0.0-beta.1
Please try it out!

Note that Windows and Mac will likely block running it by default, since it's not code-signed.
On Windows you have to say "More info", then "Run anyway", and on Mac you have to hold Control while clicking the file and then select "Open" in the menu and then "Open" in the dialog.

from jspaint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.