Git Product home page Git Product logo

Comments (3)

dekz avatar dekz commented on July 17, 2024 1

@laurengarcia thanks again. We usually lower case addresses as it can influence the order hash and is best to stick to one (either lower cased or checksummed).

Can you confirm if the order that was published used this checksummed address and not the lower case address, that is the order has 0x4448FC893284740551a5F776b4EC42cA0B010a1B not 0x4448fc893284740551a5f776b4ec42ca0b010a1b (lower case).

from 0x-launch-kit-backend.

laurengarcia avatar laurengarcia commented on July 17, 2024

Gotcha, I see what happened. The validation error was throwing from 0x Connect's .getFeeRecipientsAsync which checks the config.ts file FEE_RECIPIENT, where I had probably copy/pasted the non-lowercased version from either Metamask or Etherscan. Was not aware of the lowercase convention, but I can see it now because all of the bid/ask records in my Launch Kit instance appear to be lowercased as well.

When I .toLowerCase() the FEE_RECIPIENT address in config.ts and then query via 0x Connect's .getFeeRecipientsAsync() now there is no error.

Am going to add a comment to my local config file about lowercasing it, might want to consider doing that for 0x noobs :)

Thanks again!

from 0x-launch-kit-backend.

dekz avatar dekz commented on July 17, 2024

Yep I think we can lowercase it in launch kit safely.

from 0x-launch-kit-backend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.