Git Product home page Git Product logo

alwaysask's People

Contributors

hkan avatar nmaier avatar zpao avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

alwaysask's Issues

does not ask in some cases in 64 bit Windows 8 Firefox 31.0

I created a new Firefox (version 31.0) profile on 64 bit Windows 8 to get no extensions and no activated plugins.

Then I tested these cases before installing this addon:

Case 1 : Open a normal window, press Alt-F4 (or click the top right white cross icon) and the window closes with no dialog asking me to confirm.

Case 2 : Open a normal window, open a second tab (so two tabs in total) press Alt-F4 and a "Confirm Close" dialog window opens asking me to confirm.

Case 3 : Open a private browsing window, optionally open more tabs (so one or more tabs in total), press Alt-F4 (or click the top right white cross icon) and the window closes with no dialog asking me to confirm.

I then installed this addon in, restarted Firefox and repeated the above cases: there was no difference in behaviour.

I had expected a change in cases 1 and 3 (i.e. for a dialog asking whether I wish to close tabs).

I also repeated the above tests on a second Firefox profile that has a great many addons and config settings (some attempting to workaround mozilla's bug 419009); again there was no difference.

For completeness here are some of the settings from this second profile:

extensions.{1280606b-2510-4fe0-97ef-9b5a22eafe30}.shutdown_on_last_window_close;false
browser.tabs.closeWindowWithLastTab;true
browser.tabs.selectOwnerOnClose;true
browser.tabs.warnOnClose;true
browser.tabs.warnOnCloseOtherTabs;true
dom.allow_scripts_to_close_windows;false
extensions.{1280606b-2510-4fe0-97ef-9b5a22eafe30}.max_closed_undo;10
extensions.{1280606b-2510-4fe0-97ef-9b5a22eafe30}.save_closed_tabs;2
extensions.{1280606b-2510-4fe0-97ef-9b5a22eafe30}.save_closed_windows;2
extensions.{1280606b-2510-4fe0-97ef-9b5a22eafe30}.use_SS_closed_window_list;true
services.sync.prefs.sync.browser.tabs.warnOnClose;true

and this large one:
browser.uiCustomization.state;{"placements":{"PanelUI-contents":["edit-controls","zoom-controls","new-window-button","privatebrowsing-button","save-page-button","print-button","history-panelmenu","fullscreen-button","find-button","preferences-button","developer-button"],"addon-bar":["addonbar-closebutton","customizableui-special-spring1","status-bar"],"PersonalToolbar":["personal-bookmarks"],"nav-bar":["unified-back-forward-button","compact-menu","urlbar-container","reload-button","stop-button","search-container","webrtc-status-button","social-share-button","useragentoverrider-button","greasemonkey-tbb","bookmarks-menu-button","add-ons-button","downloads-button","ghostery-button-container","abp-toolbarbutton","widget:jid0-9XfBwUWnvPx4wWsfBWMCm4Jj69E@jetpack-self-destructing-cookies","firegloves-toolbar-button"],"TabsToolbar":["tabbrowser-tabs","new-tab-button","alltabs-button","tabs-closebutton","window-controls"],"toolbar-menubar":["menubar-items"]},"seen":[],"dirtyAreaCache":["addon-bar","PersonalToolbar","nav-bar","TabsToolbar","toolbar-menubar","PanelUI-contents"],"newElementCount":1}

Don't ask on shutdown?

This add-on works great, but there is one annoying little quirk: when shutting down/logging out, and Firefox quits, there is no point being prompted, since the action is not coming from user input... ideally it should not ask in this case. Would it be possible to implement this? If not as default behaviour, then maybe as an option.

Stopped working in Firefox 22

After upgrading Fx from 21 to 22 the extension stopped working - doesn't display any confirmation at all any longer. Same in Nightly.

Can you reproduce that?

It's possible to stack the alert messages up, which can cause Fx to crash

By pressing Cmd-Q multiple times, it's possible to stack the alert messages up. For example:

  • Press Cmd-Q to get the alert
  • Press Cmd-Q again
  • Choose either option to cancel the second alert
  • The first alert appears

It doesn't matter whether you choose OK then Cancel, or Cancel then OK… if you choose OK at any stage, Fx will quit after all alerts have been dismissed. If you choose Cancel for all alerts, it will remain open.

It's also possible to get one alert per window, as the alert seems to be modal to the window rather than the application. I think it should be application modal, like the save dialog, for example.

I've also managed to crash Fx on severl occasions by holding down Cmd-Q for a few seconds instead of pressing and then releasing - like most normal users ;-). This has caused different behaviour, which can be seen by opening multiple windows:

  • Open two windows
  • Hold Cmd-Q down for a few seconds in one of them
  • Switch windows and look at the Window menu

I've seen several different things here:

  • A few 'Quit Firefox' windows are listed, and lots with empty titles are shown
  • No 'Quit Firefox' windows are listed, and lots with empty titles are shown

Either way, Fx has normally gone on to crash or won't respond to the clicks in the quit dialogs any more... I've always had to force quit.

I'm using Fx v6.0 on Snow Leopard 10.6.8

BTW - Great extension... It certainly works nicely if you don't try and break it, although I would like to see the dialog being application modal... perhaps even get a "hold down to quit" floating message like Chrome has?

Dan

Mark as E10S-compatible

This extension is E10S-compatible, it doesn't touch content anywhere. It should be marked as such explicitly in install.rdf:

<em:multiprocessCompatible>true</em:multiprocessCompatible>

See documentation.

Change default behaviour on exit

Hello, I'd like not only to be warned on exit even if there is just one tab open, but also know if I can change the default answer to QUIT FIREFOX so that I can just press Enter without having to use the mouse to quit.
"Always ask" does the first part of the job but is there a way to set its default answer to QUIT?
Thanks

Support for private browsing

The extension doesn't prevent private tabs from being closed, if the extension is still supported, could you please add support for private browsing?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.