Comments (8)
Are you running the example unmodified?
Sent from my iPhone
On Dec 2, 2015, at 11:22, aaronkelly111 [email protected] wrote:
This is great work Alex, the speed is perfect. I've got a problem with the worker-example however, the resulting mp3 seems to have an intermittent rhythmic click presumably a side effect of the buffers getting joined together. It's not that noticeable but becomes more obvious when gain is applied afterwards.
Any ideas how to eliminate this, or somehow 'smooth/blend' the buffer edges into one another to achieve the same thing?
—
Reply to this email directly or view it on GitHub.
from lamejs.
Yeah, just running as is, nothing changed at all. It would probably be fine if I could use the resulting mp3 as is, but I need to normalize it up to a music standard 89dB. If you up the gain by running it though mp3gain (defaults to 89dB) or something similar then the clicking/cracking becomes much more obvious.
from lamejs.
I also want to say that this is a great job! But I am also experiencing small, repetitive clicking noises when recording with the mic.html example. It works fine though with the index.html converter example.
from lamejs.
I have recorded an oscillator and It looks like there are missing 5 ms every 650 ms. Here's an example on a cut out of the wave form. It should have been a smooth sine curve:
from lamejs.
Now that's a great piece of research!
Thanks
Sent from my iPhone
On Dec 6, 2015, at 12:00, Kenneth Bo Chritsensen [email protected] wrote:
I have recorded an oscillator and It looks like there are missing 5 ms every 650 ms. Here's an example on a cut out of the wave form. It should have been a smooth sine curve:
—
Reply to this email directly or view it on GitHub.
from lamejs.
Ah - got it. In worker-realtime.js, the for statement didn't run through all samples.
So in the function encode:
Change: for (var i = 0; remaining >= maxSamples; i += maxSamples){
To: for (var i = 0; remaining >= 0; i += maxSamples) {
from lamejs.
Awesome Ken! Just gave that a test and worked perfectly, great investigation and resolution!
You can generate a pull request if you want credit for the fix. If not it's a tiny edit for Alex.
Either way I'm happy to close this issue off.
from lamejs.
thanks @kenbochr @aaronkelly111
from lamejs.
Related Issues (20)
- SampleRate and normalize
- Uncaught ReferenceError: Lame is not defined HOT 9
- Math.log10 is not defined on Android 4.4's web worker HOT 1
- Mp3's LAME Version Code is wrong
- Working With MediaRecorder API HOT 1
- Dependency on module mic-recorder-to-mp3 HOT 1
- lamejs not working with angular 8 -- Uncaught ReferenceError: Lame is not defined HOT 3
- Silent MP3 file when converting output from Azure Speech-to-Text javascript SDK HOT 2
- Is it possible to use VBR (variable bit rate) HOT 1
- Blob to MP3 HOT 1
- lamejs.WavHeader.readHeader - Uncaught (in promise) TypeError: Cannot read property 'dataOffset' of undefined HOT 3
- There is a problem with the sound quality in the node environment
- Deleted
- recorder wavdata to mp3 causes ui rendering block HOT 2
- window not defined
- "MPEGMode is not defined" HOT 21
- [Firefox] Data from right channel is not passed to encoder despite there are expected two channels
- MPEGMode is not defined HOT 5
- No sound in trimmed & encoded audio blob, Vue 2. Why?
- wav转mp3的时候lampjs报"ReferenceError: MPEGMode is not defined" HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lamejs.