Comments (5)
smortex
commented on September 27, 2024
Hey @ntanaskovic, welcome to GitHub!
In order to submit your changes, please:
- Fork this repo
- Push your changes to your fork
- Create a pull request
The voxpupuli team will then be able to review your work,
Thanks!
from puppet-vault_lookup.
ntanaskovic
commented on September 27, 2024
Hi Romain,
thank you for your reply.
I've never submitted any PRs to repos on Github, but I am using git
every day for my work where we have our own Gitea server. I am familiar
with the process as I am submitting PRs to our own repositories every
day by using Linux cli tools (git and vi). In short this is what I've
done, please review and let me know what I am doing wrong:
git clone https://github.com/voxpupuli/puppet-vault_lookup
cd puppet-vault_lookup
git branch nikola
git checkout nikola
... make changes, test etc
bundle exec rake lint
bundle exec rake validate
ruby -c lib/puppet/functions/vault_lookup/lookup.rb
Syntax OK
---> syntax:manifests
---> syntax:templates
---> syntax:hiera:yaml
Now I am ready to git push my changes and create PR, but I am getting
403 (denied)
git push --set-upstream origin nikola
Username for 'https://github.com': ntanaskovic
Password for ***@***.***': (I am using my
Github token here)
remote: Permission to voxpupuli/puppet-vault_lookup.git denied to
ntanaskovic.
fatal: unable to access
'https://github.com/voxpupuli/puppet-vault_lookup/': The requested URL
returned error: 403
I appreciate your help with this.
Best regards
Nikola
…On 07/10/2021 00:24, Romain Tartière wrote:
Hey @ntanaskovic <https://github.com/ntanaskovic>, welcome to GitHub!
In order to submit your changes, please:
1. Fork this repo
<https://docs.github.com/en/get-started/quickstart/fork-a-repo>
2. Push your changes to your fork
3. Create a pull request
<https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests>
The voxpupuli team will then be able to review your work,
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APCTXP3PUHRPJZQW34FDSBLUFTLD3ANCNFSM5FPCR7DQ>.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
from puppet-vault_lookup.
smortex
commented on September 27, 2024
Good start!
So you have a git repository which is a clone of ours and a branch with your work! Next steps:
- On https://github.com/voxpupuli/puppet-vault_lookup click on the "fork" button, this will create https://github.com/ntanaskovic/puppet-vault_lookup where you can push code;
- In your repo add the remote (check that you have send your SSH key in GitHub settings. If you prefer to type in passwords, you can use the https url… both URL are visible by clicking on the "Code" green button on the page of your fork):
git remote add ntanaskovic [email protected]:ntanaskovic/puppet-vault_lookup.git - Push your branch to your fork:
git push -u ntanaskovic nikola - Open a Pull Request (I think that the post-commit message will contain the appropriate link).
Does this help?
from puppet-vault_lookup.
ntanaskovic
commented on September 27, 2024
Hi Romain,
ah it is that simple, I will keep in mind and know in the future - thank
you for your patience with me.
I have created PR just now, let me know if I need to provide any other
information.
Best regards
Nikola
…On 07/10/2021 17:28, Romain Tartière wrote:
Good start!
So you have a git repository which is a clone of ours and a branch
with your work! Next steps:
1. On https://github.com/voxpupuli/puppet-vault_lookup
<https://github.com/voxpupuli/puppet-vault_lookup> click on the
"fork" button, this will create
https://github.com/ntanaskovic/puppet-vault_lookup
<https://github.com/ntanaskovic/puppet-vault_lookup> where you can
push code;
2. In your repo add the remote (check that you have send your SSH key
in GitHub settings. If you prefer to type in passwords, you can
use the https url… both URL are visible by clicking on the "Code"
green button on the page of your fork):
git remote add ntanaskovic ***@***.***
***@***.***>:ntanaskovic/puppet-vault_lookup.git
3. Push your branch to your fork:
git push -u ntanaskovic nikola
4. Open a Pull Request (I think that the post-commit message will
contain the appropriate link).
Does this help?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APCTXPYMSLQMUBEGICOCJ43UFXDDJANCNFSM5FPCR7DQ>.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
from puppet-vault_lookup.
ntanaskovic
commented on September 27, 2024
Hi Romain,
did you get a chance to review my PR yet ? I know you guys are busy so
if there is anything that I can do to help let me know please.
Best regards
Nikola
…On 07/10/2021 19:43, Nikola Tanaskovic wrote:
Hi Romain,
ah it is that simple, I will keep in mind and know in the future -
thank you for your patience with me.
I have created PR just now, let me know if I need to provide any other
information.
Best regards
Nikola
On 07/10/2021 17:28, Romain Tartière wrote:
>
> Good start!
>
> So you have a git repository which is a clone of ours and a branch
> with your work! Next steps:
>
> 1. On https://github.com/voxpupuli/puppet-vault_lookup click on the
> "fork" button, this will create
> https://github.com/ntanaskovic/puppet-vault_lookup where you can
> push code;
> 2. In your repo add the remote (check that you have send your SSH
> key in GitHub settings. If you prefer to type in passwords, you
> can use the https url… both URL are visible by clicking on the
> "Code" green button on the page of your fork):
> git remote add ntanaskovic
> ***@***.***:ntanaskovic/puppet-vault_lookup.git
> 3. Push your branch to your fork:
> git push -u ntanaskovic nikola
> 4. Open a Pull Request (I think that the post-commit message will
> contain the appropriate link).
>
> Does this help?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#44 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APCTXPYMSLQMUBEGICOCJ43UFXDDJANCNFSM5FPCR7DQ>.
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
from puppet-vault_lookup.
Related Issues (20)
- Please release 1.1.1 with approle trailing / url fix.
- Disable Cache
- certificate failed to verify with self signed certificates HOT 1
- Server error 500 after upgrade of Puppet Enterprise 2023.5 to 2023.7
- Issue gathering multiple fields from a secret in vault HOT 1
- [Feature Request] Ability to use a list of Vault nodes HOT 3
- Specifying different login endpoint HOT 1
- Error: Failed to apply catalog: undefined method `http_ssl_instance' for Puppet::Network::HttpPool:Module HOT 2
- Per-client cert policies possible? HOT 4
- Detection of what kv version the vault is should be done via a different heuristic. HOT 2
- error: "client certificate must be supplied" HOT 2
- Agent unable to connect to Vault because of cert issue HOT 4
- bolt with approle
- undefined local variable or method 'vault_role_id'
- Retreiving a field value fails. HOT 1
- Issue authenticating to Vault using AppRole method
- Can't load environment variables from /etc/sysconfig/puppet HOT 1
- Contact Vault with Self-signed CA HOT 2
- Features: Token caching and rate-limit
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-vault_lookup.