The tinyclone from voger

In the info page the info box doesn't show the complete URL

Errors from the server don't mark the form as invalid

If we enter an invalid URL like http://www/google.com in the shortener form, the server returns an error. The error flash message appears but the form is not marked as invalid.

The bind converter function doesn't return null on empty strings

This is a frontend problem

tinyclone/tinyclone_frontend/source/class/tinyclone/elements/ShortenerForm.js

Line 78 in 0ce66a9

conveter: (data) => data ? data : null

The pages need scrollbars.

When we display long URL's the pages don't fit on the screen. They need scrollbars.

Clicking the link for info it will send us to the url instead of beeing intercepted by our application

when we create a new short url it will prompt us to visit /info/. If we click that link it will do a HTTP request to the server for that. IT should be intercepted by our javascript application and be handled by the router.

Server shortener breaks with error 500 if we use URL's over 255 characters

Example URL

http://www.qooxdoo.org/qxl.playground/#%7B%22code%22%3A%22%252F%252F%2520Document%2520is%2520the%2520application%2520root%250Avar%2520doc%2520%253D%2520this.getRoot()%253B%250Avar%2520serverUrl%2520%253D%2520%2522https%253A%252F%252Fwww.example.com%2522%253B%250Avar%2520identifier%2520%253D%2520%2522abc123%2522%253B%250Avar%2520message%2520%253D%2520'click%2520this%2520and%2520you%2520will%2520go%2520to%2520%253Ca%2520href%253D%2522%25251%252F%25252%2522%2520%2520target%253D%2522_blank%2522%253E%25251%252F%25252%253C%252Fa%253E%253Cbr%253E'%2520%252B%2520%250A%2520%2520%2520%2520%2520%2520%2520%2520%2520%2520%2520%2520%2520%2520%2520'click%2520this%2520and%2520it%2520will%2520show%2520a%2520popup%2520%253Ca%2520href%253D%2522%25251%252F%25252%2522%253E%25251%252F%25252%253C%252Fa%253E'%253B%250Avar%2520formated%2520%253D%2520qx.lang.String.format(message%252C%2520%255BserverUrl%252C%2520identifier%255D)%253B%250A%250Avar%2520label%2520%253D%2520new%2520qx.ui.basic.Label(formated).set(%257B%250A%2520%2520rich%253A%2520true%250A%257D)%253B%250A%250A%252F%252F%2520Add%2520label%2520to%2520document%2520at%2520fixed%2520coordinates%250Adoc.add(label%252C%250A%257B%250A%2520%2520left%2520%253A%252010%252C%250A%2520%2520top%2520%2520%253A%252050%250A%257D)%253B%250A%250A%22%2C%20%22mode%22%3A%22ria%22%7D

The server crash with

[error] #PID<0.656.0> running TinyCloneWeb.Endpoint (connection #PID<0.654.0>, stream id 2) terminated
Server: localhost:4000 (http)
Request: POST /api/
** (exit) an exception was raised:
    ** (Postgrex.Error) ERROR 22001 (string_data_right_truncation) value too long for type character varying(255)
        (ecto_sql) lib/ecto/adapters/sql.ex:629: Ecto.Adapters.SQL.raise_sql_call_error/1
        (ecto) lib/ecto/repo/schema.ex:656: Ecto.Repo.Schema.apply/4
        (ecto) lib/ecto/repo/schema.ex:262: anonymous fn/15 in Ecto.Repo.Schema.do_insert/4
        (ecto) lib/ecto/multi.ex:585: Ecto.Multi.apply_operation/5
        (elixir) lib/enum.ex:1948: Enum."-reduce/3-lists^foldl/2-0-"/3
        (ecto) lib/ecto/multi.ex:569: anonymous fn/5 in Ecto.Multi.apply_operations/5
        (ecto_sql) lib/ecto/adapters/sql.ex:903: anonymous fn/3 in Ecto.Adapters.SQL.checkout_or_transaction/4
        (db_connection) lib/db_connection.ex:1427: DBConnection.run_transaction/4
        (ecto) lib/ecto/repo/transaction.ex:20: Ecto.Repo.Transaction.transaction/4
        (tinyclone) lib/tinyclone/shortener.ex:48: TinyClone.Shortener.shorten/2
        (tinyclone) lib/tinyclone_web/resolvers/shortener.ex:5: TinyCloneWeb.Resolvers.Shortener.create_link/2
        (absinthe) lib/absinthe/resolution.ex:206: Absinthe.Resolution.call/2
        (absinthe) lib/absinthe/phase/document/execution/resolution.ex:209: Absinthe.Phase.Document.Execution.Resolution.reduce_resolution/1
        (absinthe) lib/absinthe/phase/document/execution/resolution.ex:168: Absinthe.Phase.Document.Execution.Resolution.do_resolve_field/4
        (absinthe) lib/absinthe/phase/document/execution/resolution.ex:153: Absinthe.Phase.Document.Execution.Resolution.do_resolve_fields/6
        (absinthe) lib/absinthe/phase/document/execution/resolution.ex:72: Absinthe.Phase.Document.Execution.Resolution.walk_result/5
        (absinthe) lib/absinthe/phase/document/execution/resolution.ex:53: Absinthe.Phase.Document.Execution.Resolution.perform_resolution/3
        (absinthe) lib/absinthe/phase/document/execution/resolution.ex:24: Absinthe.Phase.Document.Execution.Resolution.resolve_current/3
        (absinthe) lib/absinthe/pipeline.ex:274: Absinthe.Pipeline.run_phase/3
        (absinthe_plug) lib/absinthe/plug.ex:421: Absinthe.Plug.run_query/4

Make the url customizable via environment variables

The web server URL should be customizable and the API must return that URL

Sending a query with empty string as custom identifier forces endless recursion

This must be fixed in backend. identifier is an empty string and it loops forever

voger / tinyclone Goto Github PK

tinyclone's People

Contributors

Watchers

tinyclone's Issues

In the info page the info box doesn't show the complete URL

Errors from the server don't mark the form as invalid

The bind converter function doesn't return null on empty strings

The pages need scrollbars.

Clicking the link for info it will send us to the url instead of beeing intercepted by our application

Server shortener breaks with error 500 if we use URL's over 255 characters

Make the url customizable via environment variables

Sending a query with empty string as custom identifier forces endless recursion

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent