Git Product home page Git Product logo

Comments (6)

greenkeeper avatar greenkeeper commented on September 27, 2024

After pinning to 2.4.0 your tests are passing again. Downgrade this dependency 📌.

from sequelize.

SimonSchick avatar SimonSchick commented on September 27, 2024

@felixfbecker This is also an issue on the latest version of TypeScript, It's not possible to use pass any class inheriting from Model as typeof Model due to the error showing in the travis build.

from sequelize.

SimonSchick avatar SimonSchick commented on September 27, 2024

@felixfbecker I think I found the problem, in many case you use keyof this rather than a generic.

eg. changed(key: keyof this): boolean; to changed<K extends keyof this>(key: K): boolean;

from sequelize.

felixfbecker avatar felixfbecker commented on September 27, 2024

I don't understand why that would be a problem with the type system?

from sequelize.

SimonSchick avatar SimonSchick commented on September 27, 2024

I changed the typings manually and that fixed the problem.

Not sure what exactly the issue is but I assume it restricts the to keyof this in context of the Model class instead of the actual child class.

from sequelize.

SimonSchick avatar SimonSchick commented on September 27, 2024

@felixfbecker this still makes these typings unusable for latest TS.
I'm currently vendoring the typings to avoid this error, any chance you will update? 😄

from sequelize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.