test fails without feature tls12 about tls HOT 6 OPEN

Thanks for the kind suggestion, but no - for political reasons: Github Terms of Service arguably contains a special licensing clause which is not problematic for liberally licensed code like this project but effectively weakens stronger copyleft licensed code. I therefore never push code to Github.

I already shared the code change as a patch. Please tell me if helpful to you that I provide it as a git branch that you can clone and merge. I fully understand if you have no interest in playing along with my policital game, though.

from tls.

What test command are you running?

from tls.

Sorry, I forgot to copy that and no longer have that build log lying around - but it was likely cargo test --all-targets --no-default-features.

I am packaging this crate for Debian, and run tests in various feature combinations.

from tls.

This one-line fix solved the issue for me: https://salsa.debian.org/debian/rust-tokio-rustls/-/blob/debian/latest/debian/patches/1001_tls12.patch

--- a/tokio-rustls/tests/badssl.rs
+++ b/tokio-rustls/tests/badssl.rs
@@ -32,6 +32,7 @@
 }
 
 #[tokio::test]
+#[cfg(feature = "tls12")]
 async fn test_tls12() -> io::Result<()> {
     let mut root_store = rustls::RootCertStore::empty();
     root_store.add_server_trust_anchors(webpki_roots::TLS_SERVER_ROOTS.0.iter().map(|ta| {

Good catch, would you like to open a PR?

from tls.

Anyone else feel like fixing this?

I notice that a new release went out, without this getting fixed :-(

from tls.