swistak / spree-promotions Goto Github PK

There are numerous errors and failing tests.

rake extensions:test

We might as well give the option to limit by zone for user discounts (and eventually coupons although that is a core issue we can talk about later.)

We're using edge (updated yesterday morning) and we have some custom helpers in our site extension:

vendor/extensions/site/app/helpers/site_helper.rb
module SiteHelper
def product_listing_name(product)
product.name.gsub(" - ","
")
end
end

We set them up for use in site_extension.rb:
def activate
Spree::BaseController.class_eval do
helper SiteHelper
end
end

These work fine until we install the promotions extension, at which point we start receiving "undefined method `product_listing_name' for #ActionView::Base:0x1072fd278", the full stack trace is below.

I believe we have fixed the issue at: http://github.com/recruitmilitary/spree-promotions/tree/errors-when-loading

I don't know exactly why this fixes it though. I do know that it is unnecessary to call "helper 'promotions'" on ProductsController as it inherits from Spree::BaseController.

Hi,

I have a problem creating user promotions (in Edge version of spree) using the admin ui, After fill in the fields when clicked create it always give me the same error that says "is too short (minimum is 2 characters)" below the name field.

But I can create user promotions in the console and work perfectly.

I've modified /lib/promoted_products.rb with:

def promoted_products
# promoted.is_a?(Product) ? [promoted] : promoted.products.all
if promoted.is_a?(Taxon)
Product.in_taxon(promoted)
elsif promoted.is_a?(Product)
[promoted]
else
promoted.products.all
end
end

On the new promotion form I see a translation missing for "calculator, free-shipping" in the select box.

There appears to be a mismatch between what parm name is submitted (first_purchase_promotion) vs. what resource_controller attempts to retrieve(product_promotion), resulting the 'update' of a promotion not having any effect.

From my limited knowlege and a little digging around, it seems that we might need to do something with resource_controller's def object_name / def model-name (from the readme).

Has anyone gotten this working? Because no one else has had this problem, it makes me wonder if I'm doing something really silly.

I'm running edge spree (and subsequently upgraded to the latest version of the resource_controller plugin in an attempt to get things working).

Thanks

Calendar popup (the jquery one) should probably be added to the date fields. See admin/orders for example.