sunet / cnaas-front Goto Github PK

Is your feature request related to a problem? Please describe.

Currently, the "Firmware" tab shows up at the top of the page regardless if cnaas-nms supports firmware updates for the current vendor or not.
It seems like firmware updates are currently mostly an Arista thing but do not work for Juniper -- so for us, this tab is not useful right now.
Making the tab optional would be a way to make the frontend more vendor-independent.

Describe the solution you'd like

I'd suggest the tab to be optional and only show up when the CNAAS_FIRMWARE_URL environment variable is set and non-empty.
If CNAAS_FIRMWARE_URL is set: Show the tab.
Otherwise: Tab is not visible.

Describe alternatives you've considered

Ignoring it? ;) Still every new person I tell about the frontend needs to be told "sorry, we currently can't use this!"

Additional context

It's a really small niggle, I admit that. Still I'd like seeing this fixed.

In various docker-files, you install 3rd party python libraries like this:

$ pip install dependency1 dependency2 ..

Sooner or later, these dependencies will need different versions of a sub-dependency, and then pip will fail because of a version conflict.

I recommend that you put these dependencies in requirements-files with version numbers and install them like this:

$ pip install -r requirements-for-subsystem-1.txt

You can generate a requirements file with pip freeze or better: pip-compile from piptools.

By using the same requirements-files everywhere you can make reproducible deploys, and also test on the actual versions that will be deployed. Much recommended!

Describe the bug
When doing a dry-run to a group of switches and one of them is unreachable you get a long python stack trace in the NMS GUI.

Steps to reproduce the behavior:

• Make one switch unreachable
• Perform a dry-run

Expected behavior:

• Instead of getting 50 lines of stack trace It would be preferable if it was handled with some kind of message saying the device could not be reached or something like that.

Environment:
CNaaS-NMS version: 1.2.1