Git Product home page Git Product logo

Comments (4)

artembilan avatar artembilan commented on April 19, 2024 1

What about that write a log for caution to programmers at this situation?

Well, I'd say that it is better to forward such a request to the RabbitMQ client directly.

Since com.rabbitmq.client.Channel.queueDeclare() doesn't throw any warnings, I don't see reason to overhead that on the Spring AMQP level.

When amqp-client will react somehow to that condition, Spring AMQP will propagate it transparently.

from spring-amqp.

artembilan avatar artembilan commented on April 19, 2024

Well, actually you have two different declarations for the same queue.
So, even if we throw IllegalArgumentException and you'd fix inconsistency, your second false for the exclusive will lead to similar PRECONDITION_FAILED.

Queue queueForTest2 = new Queue(queueName, false, true, false);

makes your test to pass.

To be consistent with the RabbitMQ spec, I don't see reason to break that rule and throw unexpected IllegalArgumentException , where all other clients just reconfigure request silently.

from spring-amqp.

SehoNoh avatar SehoNoh commented on April 19, 2024

yeah, I know that the second queue would better to replace with

Queue queueForTest2 = new Queue(queueName, false, true, false);

to pass the test or using just like that.
And you mean that we don't need to fix up the programmer's logical (I think it's logical) mistake?

Then, What about that write a log for caution to programmers at this situation?

from spring-amqp.

SehoNoh avatar SehoNoh commented on April 19, 2024

I see, I exactly understand what you saying.
Thanks for your lecture, it helps me alot :)

from spring-amqp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.