Comments (6)
Most likely than not, none of those needs to be Serializable
. I think we can remove those implements
and see what breaks. Either you will get a compile error, or a brand new SE_BAD_FIELD
report somewhere else on the chain.
The only of those that seems to have any reason to be Serializable
is BugInstance
due to the cloud plugins, but that is gone now, so it's most likely useless.
from spotbugs.
maybe BugInstance was for cloud? no idea
from spotbugs.
I've been looking into this, it seems to stem down from the fact that MainFrame
, as an awt component, is Seralizable
.
AWT serialization is not used. It's mainly intended for Applets (not our case) and may be used for a sort-of prevalence, but it's not our intended use case either.
We should probably just mark those fields as transient
on MainFrame
, implement readObject
with something along the lines:
private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundException {
in.defaultReadObject();
// re-init non-serializable fields
logger = new ConsoleLogger(this);
backgroundExecutor = Executors.newCachedThreadPool();
mainFrameInitialized = new CountDownLatch(1);
....
}
from spotbugs.
i think you can just rip it all out with impunity
from spotbugs.
Yeah, that could also be, but we would have to suppress the SE_BAD_FIELD
warnings on the awt compontents.
@ThrawnCA will you take this over now or shall someone else do it?
from spotbugs.
Resolved on #85
from spotbugs.
Related Issues (20)
- Array index out of bounds exception on `FindDeadLocalStores` HOT 8
- Index out of bounds for empty switch HOT 3
- spotbugs-4.8.5.zip contains duplicate log4j-core-xxx.jar HOT 1
- False positive with XXE_SCHEMA_FACTORY (and possibly similar rules) when setting properties in separate method HOT 2
- False positive EI_EXPOSE_REP when copyOf or Collections::unmodifiable* is used with Java Record and Optional HOT 4
- False positive EI_EXPOSE_REP when use Collections.emptySet, emptyList or emptyMap is used
- Disable output during Maven goal `spotbugs:check` as redundant with site generation HOT 4
- Asked to end timing for class X but top of stack is class Y remaining stack is [edu.umd.cs.findbugs.log.Profiler HOT 3
- false positive SING_SINGLETON_GETTER_NOT_SYNCHRONIZED with synchronized initialization-method HOT 3
- Facing issues using spotbugs plugin 6.0.19 with Java 17 HOT 3
- Issue during analysis of SpringCGLIB after Spring Boot Native build HOT 13
- Here's a sample code snippet to check if a given string matches a date format HOT 3
- False positive NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE when using Nullable annotations with TYPE_USE
- missing close() call not reported in certain cases HOT 6
- Lombok @Getter(lazy = true) causes JLM_JSR166_UTILCONCURRENT_MONITORENTER + RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE HOT 7
- Irrelevant `NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR` for Kotlin data classes HOT 3
- The MacOS builds fail HOT 3
- SpotBugs 4.8.6: Missing DLS_DEAD_LOCAL_STORE warning for primitive types HOT 4
- The documation on the annotations should state which depdency is required HOT 2
- False negative: Spotbugs should complain when storing returned Nullable into NonNull variable HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spotbugs.