Comments (13)
Any ideas for a more robust way of finding YADR? It does only look in first level directories in home so if you moved it out of home it would have worked.
from dotfiles.
I moved it into something in the home folder.
Your detection mechanism, if I have it right, is to scan all directories 1 level deep in $HOME/ and look for a file called .yadr, and if it exists, that's your YADR install folder.
I'd say go the opinionated way and just declare "it has to be in .yadr" skip the search.
Or if you want to keep the search - add something that varies and gets added during install - have a version in the contents of the .yadr file that your install script looks for, and have it updated in the Rakefile along with the .yadr file so you can't accidentally install twice. New version = updated rakefile = updated yadr file.
I'd go with the simple "it lives in .yadr - it's opinionated, remember?"
from dotfiles.
Oh, and for all issues (more releavnt to the install/update procedure) - I'd say try to stick to standard system default tools by full path for install/remove/upgrade procedures as much as possible rather than ruby/etc. if someone (like me) has mucked with system path settings outside of just the shell (like in OSX, launchd, etc) it would get unpredictable.
from dotfiles.
@skwp what do you think about this? Searching for .yadr is a bit of a PITA, but I know you're worried about backwards compatibility.
from dotfiles.
I think too much magic is bad. I woudl actually prefer to go back to the old way of saying yadr has to be in ~/.yadr and end of story. People can always symlink it if they want to keep it in dropbox or what have you. Instead of engineering more and more complex ways of dealing with it, let's take a stand on where it should live and simplify everyone's lives?
from dotfiles.
So I like @dedward idea of going back to saying ~/.yadr or bust
from dotfiles.
agreed. if we can decree it lives in .yadr I can get to work on #58 too.
from dotfiles.
yeah let's do that. Do you want to do it or should I?
from dotfiles.
I can commit some time later this week. If you can merge in #65 #66 before I get going that may save me a merge.
from dotfiles.
merged, thanks. there was a smal bug with aliases.zsh reference but I fixed it. please make sure the readme is up to date with the new stuff when you're done :) thanks @kylewest !
from dotfiles.
I do prefer to hardcode to ~/.yadr rather than leaving that configurable. That's extra complexity for very little reason..
from dotfiles.
Guys can you please review https://github.com/tUrG0n/dotfiles/commit/31fc64152d14d09df7cf877897b6bd7e68d511a9#commitcomment-1740200 to see if it solves the hardcoded location issue
from dotfiles.
I'm going to close this in favor of code being developed in #131. Please comment or reopen if appropriate.
from dotfiles.
Related Issues (20)
- Homebrew halts installation on a fresh MacOS HOT 1
- Vim suspends in some times HOT 5
- vim-coc install blocked by our vim plugin manager (Vundle)? HOT 4
- add rebase = false for git pull in .gitconfig pls HOT 2
- neocomplete is deprecated HOT 1
- alt + backspace stopped to work HOT 1
- Gsearch never finds anything HOT 2
- migration to vim-plug HOT 1
- FUNCNEST error when using .zsh.after to configure starship prompt HOT 3
- Is this repo still being maintained? HOT 3
- Neocomplete is no longer compatible with Vim versions 8.2.1066+ HOT 8
- After installing the dotfiles, my `Ctrl + f/b/p/n/h/d` can not used anymore HOT 1
- bashcompinit:140: parse error near `-l' HOT 1
- Unable to install yadr due to issue w/ Chezmoi and nproc? HOT 2
- Compatibility issue with YADR and NVM. NVM always installs from source HOT 3
- Reviewing .zshrc and getting nowhere fast, HOT 1
- Warning in terminal regarding egrep obsolescence HOT 1
- Fasd deprecated HOT 1
- Homebrew path changed HOT 1
- Issue with .exists? for ruby 3.2 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dotfiles.