React native reference error in 0.5.1 about ky HOT 8 CLOSED

Proposal:

If document.baseURI doesn't exist and the input is a relative URL:

• ...if the prefixUrl option is not set, we throw an error recommending the user to set that option.
• ...if the prefixUrl option is set, we just don't use document.baseURI.

Thoughts?

from ky.

After further investigation it seems to come from the following line of code:

This was added in the 0.5.1 with commit d6f8176 which fixed issue #59. As document is not available in React-Native I am not sure if this issue is in the scope for this library and what a clean fix would be if it is in the scope.

from ky.

This is also a problem when trying to use ky in a SSR React app. I'd love to use ky, as it's much easier to handle than direct fetch or alternatives.

Is support for SSR something you'd still consider part of this library? The _globalThis polyfill in the main index.js seems to suggest that.

from ky.

Is support for SSR something you'd still consider part of this library?

Yes

from ky.

We just need to decide how Ky should handle document.baseURI not being available.

from ky.

Cool! In the meantime, I solved the situation in my NextJS app by adding things like Headers and document to the global object server side. I used node-fetch to get working implementations of these.

import fetch, { Headers } from 'node-fetch'

const BASE_URL = 'http://some.url'

if (typeof window === 'undefined') {
  global.document = {
    baseURI: BASE_URL,
  }
  global.fetch = fetch
  global.Headers = Headers
}

Ky's _globalThis polyfill automatically picks up global and things work as expected.

@sindresorhus, are you already tracking this topic in a different issue? Do you have an intuition for how you'd want to see this handled?

from ky.

Presumably these environments have some way to get the current URL, right? For example, an equivalent of location.href.

That would be the appropriate fallback when no DOM is present.

from ky.

@sholladay, well when you are running in plain node, then I would think, no. Most common scenario that comes to mind, and which I ran into, is a React page being rendered inside of an express app. I don't see how ky could be made aware of the original HTTP request causing the page render, without requiring quite some developer effort.

from ky.