Incomplete cache files on interrupted requests about gonic HOT 6 CLOSED

Thank you both very much for finding and fixing this. I kept hitting this intermittently, and I knew it was a gonic bug, but I could never actually reproduce it on command. Cheers!

from gonic.

Or this: https://www.youtube.com/watch?v=B5NoXaSajq0 :)

from gonic.

ah you're right, thanks! do you think about this approach? ce31310

which is to make Transcode() return an error when it was killed (for example when the http request was terminated early)

that way we hit the caching transcoders case of deleting cache files. and we don't need to worry about deleting any temp files

from gonic.

I'll check if it works with the case I found and will let you know. :)

Actually, I was thinking about letting ffmpeg finish writing the output into the cache file even if request was terminated, but this approach can be undesirable in some cases (e.g. if you accidentally tapped on a 40-minute-long one-track album 😁).

from gonic.

As a bonus, you can have a laugh at one track that got mangled on my phone:
https://magada.ga/shared/fuef.m4a.gpg

Use gpg to decrypt it with a password (the password is the name of this project). ;)

from gonic.

As a bonus, you can have a laugh at one track that got mangled on my phone: https://magada.ga/shared/fuef.m4a.gpg

Use gpg to decrypt it with a password (the password is the name of this project). ;)

😁 thats hilarious, the drumming reminds me of this https://www.youtube.com/watch?v=CNhhXmXQ_bY

from gonic.