Git Product home page Git Product logo

Comments (6)

sperand-io avatar sperand-io commented on September 28, 2024

@benhardy I can't imagine we wouldn't :) I'll defer to @f2prateek on the mechanics of how we'll bring it in and what branch to open it against, but just wanted to thank you for offering to contribute!

We'll be in touch shortly with next steps

from analytics-java.

benhardy avatar benhardy commented on September 28, 2024

Cheers, my pleasure.

from analytics-java.

f2prateek avatar f2prateek commented on September 28, 2024

@benhardy Can you share more details about the patch? Do you have a commit on Github?

from analytics-java.

benhardy avatar benhardy commented on September 28, 2024

Here's a diff against 1.0.7. All it does is make sure HttpResponses get closed. This was enough to ensure that connections in the pool can get reused efficiently. We saw after upgrading some services to Jetty 9.3. that the analytics library would just lock up because it was holding onto connections too long and timing out. This fixes that.

Commit: benhardy@b3656d1

Diff: analytics-1.0.7...benhardy:1.x

from analytics-java.

madisp avatar madisp commented on September 28, 2024

We're also operating with a fork that fixes #71. If there is going to be a 1.0.8 I'd be happy to create a PR so it could get in.

from analytics-java.

f2prateek avatar f2prateek commented on September 28, 2024

We'll make a 1.0.8 release to accomodate these fixes. I don't have an exact plan yet, but I'll post back with how to proceed.

I would still highly recommend using the v2 releases (even as a fork if you need Java 6 support). There are significant architectural changes and bug fixes for cases like this.

from analytics-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.