Comments (6)
@benhardy I can't imagine we wouldn't :) I'll defer to @f2prateek on the mechanics of how we'll bring it in and what branch to open it against, but just wanted to thank you for offering to contribute!
We'll be in touch shortly with next steps
from analytics-java.
Cheers, my pleasure.
from analytics-java.
@benhardy Can you share more details about the patch? Do you have a commit on Github?
from analytics-java.
Here's a diff against 1.0.7. All it does is make sure HttpResponses get closed. This was enough to ensure that connections in the pool can get reused efficiently. We saw after upgrading some services to Jetty 9.3. that the analytics library would just lock up because it was holding onto connections too long and timing out. This fixes that.
Commit: benhardy@b3656d1
Diff: analytics-1.0.7...benhardy:1.x
from analytics-java.
We're also operating with a fork that fixes #71. If there is going to be a 1.0.8 I'd be happy to create a PR so it could get in.
from analytics-java.
We'll make a 1.0.8 release to accomodate these fixes. I don't have an exact plan yet, but I'll post back with how to proceed.
I would still highly recommend using the v2 releases (even as a fork if you need Java 6 support). There are significant architectural changes and bug fixes for cases like this.
from analytics-java.
Related Issues (20)
- Java library does not correctly measure the size of messages in the queue, causing overly large requests HOT 10
- Callback use inconsistency
- Request to update Changelog.md HOT 1
- Add module descriptiors to the public libraries HOT 2
- Include working sample code in the Java docs HOT 1
- Is com.segment.analytics.Analytics thread-safe? HOT 6
- Including sentAt in the Batch body of the HTTP request forces the use of a segment server computed timestamp HOT 4
- Analytics Java 3.2.0 does not attempt to send event if it exceeds 32kb and only logs error without returning it from function HOT 1
- Changelog Missing for 3.2.0
- Null traits HOT 2
- Add Testing for IBM JVM HOT 3
- Unable to use Segment with JDK 17 HOT 2
- Large message size for analytics.enqueue leads to thread interrupt HOT 1
- [3.4.0] writeKey is not passed in Authorization header HOT 1
- Convert to Github Actions HOT 1
- Remove reliance on java.util.Date in favor of the newer Date-Time APIs HOT 2
- Minimum analytics-java version to run with JDK 17 and Spring Boot 3?
- Missing okio-jvm runtime dependency HOT 4
- Segment's MessageBuilder context is write-only which prevents additive context building HOT 1
- update javax annotations to jakarta annotations HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from analytics-java.