Chimney >= 0.8.0 can't transform case class with annotated parameter about chimney HOT 7 CLOSED

Couldn't reproduce in Scastie:

• 0.7.5 compiles in Scastie
• 1.2.0 compiles in Scastie as well

Then the reproduction from https://github.com/little-inferno/chimney-error worked.

However, commenting out

//ThisBuild / scalacOptions += "-Ymacro-annotations"

make the code work again. I am not sure what is the cause, but presence of "-Ymacro-annotations" changes what macros sees internally, I suspect that we might have a workaround for such cases which did not survive the rewrite as it's difficult to have a regression test for something as unpredictable as compiler flag changing the data available to the macro. I might take a look at this somewhere in the next week if I'll have the time.

from chimney.

I have something local, but I'd need to add regression tests to make sure it works and would keep working.

from chimney.

As far as I tested the fix I merged worked. I tested with local snapshot, once https://github.com/scalalandio/chimney/actions/runs/9761346064/job/26942175116 passed you might check as well with a Sonatype OSS shapshots.

from chimney.

Yes, it seems that using -Ymacro-annotations change decoded name from

apply$default$idx

to

<init>$default$idx

And this matching give an error

I wrote dirty quickfix and it fix compilation errors in https://github.com/little-inferno/chimney-error

from chimney.

My local fix was quite similar to your - I'd add a test for default value in a class which is not case class, and maybe something with -Ymacro-annotations. I suspect that missing tpe.typeSymbol.typeSingature was the issue, since there was an unfixed bug in Scala 2 macros when sometimes type symbol is not initialized until this method is called (even if it's completely not needed). But I haven't tested this PR at all.

from chimney.

Great, there are no more errors with the default parameters 🎉

from chimney.

Released in 1.3.0

from chimney.