Git Product home page Git Product logo

Comments (7)

rohankapoorcom avatar rohankapoorcom commented on September 27, 2024 2

Home Assistant is designed so that multiple integrations can add entities to the same device so that they fit together in the UI in the system (and naming is automatically done). That's how I originally implemented this for this integration. I don't think it makes sense to revert that functionality and fixing it. Home Assistant does regularly change interfaces for internal integrations, making changes to support that is normal. If this was an internal integration (living directly in Home Assistant repo), it would have been fixed as part of the merge of that change.

from valetudo_vacuum_camera.

sca075 avatar sca075 commented on September 27, 2024 2

Home Assistant is designed so that multiple integrations can add entities to the same device so that they fit together in the UI in the system (and naming is automatically done

Hopefully we will not need to change it.. as well there are changes on MQTT that we will need to study ;)

from valetudo_vacuum_camera.

sca075 avatar sca075 commented on September 27, 2024 1

Long ago was introduced in this "integration" the configuration of the camera as part of the vacuum entity.

We currently have two possible solutions.

  1. Fully integrate the vacuum.. that in order words can be discovered as there's a discovery future in the vacuum.

  2. revert the camera as an HA entity separate from the vacuums (not visible in MQTT). This would be a braking change for your configurations as the entity id will change.

As per the 2024.6.0 of HA will be published on next Monday.. would probably go for the number 2. Also because there was a kind agreement with the vacuums developers to do not integrate the vacuums with this custom component.

from valetudo_vacuum_camera.

jgkawell avatar jgkawell commented on September 27, 2024 1

Yeah I think the second option makes a lot of sense. It's more explicit to have it as a separate entity anyway and though it means updating dashboards/automations it should avoid issues in the future.

from valetudo_vacuum_camera.

sca075 avatar sca075 commented on September 27, 2024 1

@jgkawell there was probably an issue with the HassKey that replaced the get_mqtt_data on the new version of Home Assistant, I'm currently downloading the 2026.6.0b2 and we will see if it will be necessary to go for the solution two.
In any case in the begging the camera was design to be a stand alone. So probably if this patch that I will commit in few minutes (that include also some modification that should fix #160).. I will later consider to move ahed with this.

from valetudo_vacuum_camera.

sca075 avatar sca075 commented on September 27, 2024

Solution tested on pull #162 will publish soon the fix for issue #161! :)

from valetudo_vacuum_camera.

sca075 avatar sca075 commented on September 27, 2024

Confirmed also boot after installing the 2024.6.0b3, I think this 2024.06.1 will work at 100%.

from valetudo_vacuum_camera.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.