robpruzan / react-scratch Goto Github PK

When the conditionally rendered node is the first child of the parent node, as shown in the code below, the position of this node is not inserted as expected as the first child of the parent when it changes from an empty node to a real node.

This seems to be because the 'updateDom' method only concerns itself with the 'lastUpdatedSibling', and the first child node does not have a 'lastUpdatedSibling'.

Hi @RobPruzan - I absolutely loved your post about this library.

I really wanted to follow along with the post and see these steps for myself in code. I knew there would be some exercises left to the reader, so I opened up this codebase alongside the post.

Unfortunately, there's enough drift between the post and this code base that I couldn't really do the thing I wanted: follow a step-by-step guide to building this codebase (mostly).

I get the sense that's not the intention of your post, so I hope this issue doesn't read as a complaint. Instead, I'd love to just encourage you to create a supplemental resource, or a course, or something else that does a deep dive on this code and walks through the process step-by-step.

In fact, I'd be willing to pay you at least $40 for a resource like that. I'd even pay in advance. This is about how much Rebuilding Rails costs, and it's one of the best books I ever read back when I was writing Ruby on Rails code. I think what you've done here could be like that, but for React.

I don't know you or your life or anything, so if that's not interesting to you, all good. But I wanted to write this to thank you for the very interesting read, for publishing this code base, and I wanted to let you know you have at least one paying customer ready to go on this one.

Thanks for putting this out there into the world. Have a great week!