get_members() returns meetup join date instead group join date about meetupr HOT 13 OPEN

working on issue #31 so i can have test coverage for this one.

from meetupr.

@limegimlet Thanks for the report! I checked to make sure joined actually means "when the user joined the group" rather than "when the user joined meetup.com", and according to the docs, it sounds like it's supposed to be when they joined the group.

It seems to be a bug. What I see is that R-Ladies Paris was created on "2016-09-19 08:39:51 PDT" and I have verified that this date is correct, so then I checked the dates that people joined and I see this:

> mem <- get_members('rladies-paris')
> range(mem$joined)
[1] "2007-03-13 08:14:36 PDT" "2018-01-30 02:22:53 PST"

We do some parsing of the date (maybe it's being parsed incorrectly), and if that's not the issue then either the meetup.com API is returning the wrong values or their documentation is wrong (and it's actually showing the date they joined meetup.com).

You're the first entry in the members table, and it says you joined on "2008-11-15"... is that the date you joined meetup.com, by chance?

from meetupr.

from meetupr.

I started looking at reproducing this awhile ago, I'm digging that back up.

from meetupr.

I have reproduced and demonstrated this issue. The value you want is "group_profile.created".

http://rpubs.com/rladiespdx/meetup-member-dates

I also confirmed, the docs are weird.

Under Sort "joined" refers to sorting the member list by when the member joined the group:
Sort
joined
Time member joined this group

Under Response:

joined
Time member joined, represented as milliseconds since the epoch

Under Group Profile (I think this is what you want):

created
The time this member joined the Group, represented as milliseconds since the epoch

from meetupr.

I need to look at the code to figure out what makes the most sense as far as a patch proposal.

from meetupr.

Removed help wanted since I'm working on this :)

from meetupr.

@missaugustina, are you still working on this? Might it help if I had a look? I am not skilled with formal testing but I have used this package a great deal (please see http://bit.ly/2NEHVGn). So I could at least explore capturing group_profile.created.

from meetupr.

@missaugustina @RickPack Anyone have an update on this? Someone ran into this bug again today and so it reminded me to come here and check the status. Let me know and we can re-assign the issue if necessary. Thanks!

from meetupr.

I came to the same problem today,
is there any updates?

from meetupr.

I missed my name mention. This issue was not assigned to me. It looks like @missaugustina was going to address the issue.

from meetupr.

@RickPack @missaugustina @ledell
I solved it doing this:
1 download json file of members per chapter
2. convert it to a csv
3. mutate the column group_profile.created
mutate(date_joined = lubridate::floor_date(as.POSIXct( group_profile.created/1000, tz = "UTC", origin = "1970-01-01")))

I guess the the mutate on step 3 should be added to the function get_members, and that would be it.

from meetupr.

@ledell what needs to happen here? Do we need to not use what the API returns for that date?

from meetupr.