Git Product home page Git Product logo

Comments (4)

alistair23 avatar alistair23 commented on September 27, 2024

Interesting, GCC9 is pointing out something which is a bad idea to have in code. For RISC-V it shouldn't cause catastrophic problems, but will slow things down. Even then our struct should always be aligned, so this really won't cause us any issues for us.

For more details you can read the GCC bug report that started this: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51628

I'll work on a patch, I think an intermediate variable will fix it, as that way we never take an address of a packed struct. A little bit of a pain, but I don't see a much better solution.

from opensbi.

alistair23 avatar alistair23 commented on September 27, 2024

@kraj Do you have a branch with GCC9 that I can use?

from opensbi.

kraj avatar kraj commented on September 27, 2024

Use Yoe Distro ( shameless plug ) which I co-maintain and use yoe/mut branch
https://github.com/YoeDistro/yoe-distro

or you can use yoe/mut branch from my contrib repo
https://github.com/YoeDistro/openembedded-core/tree/yoe/mut

and in local.conf set

GCCVERSION = "9.%"

from opensbi.

kraj avatar kraj commented on September 27, 2024

Interesting, GCC9 is pointing out something which is a bad idea to have in code. For RISC-V it shouldn't cause catastrophic problems, but will slow things down. Even then our struct should always be aligned, so this really won't cause us any issues for us.

I think we should avoid typecasting packed structs to pointers, or not pack them

For more details you can read the GCC bug report that started this: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51628

Yes I am aware of that

I'll work on a patch, I think an intermediate variable will fix it, as that way we never take an address of a packed struct. A little bit of a pain, but I don't see a much better solution.

that will be awesome

from opensbi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.