Comments (4)
Interesting, GCC9 is pointing out something which is a bad idea to have in code. For RISC-V it shouldn't cause catastrophic problems, but will slow things down. Even then our struct should always be aligned, so this really won't cause us any issues for us.
For more details you can read the GCC bug report that started this: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51628
I'll work on a patch, I think an intermediate variable will fix it, as that way we never take an address of a packed struct. A little bit of a pain, but I don't see a much better solution.
from opensbi.
@kraj Do you have a branch with GCC9 that I can use?
from opensbi.
Use Yoe Distro ( shameless plug ) which I co-maintain and use yoe/mut branch
https://github.com/YoeDistro/yoe-distro
or you can use yoe/mut branch from my contrib repo
https://github.com/YoeDistro/openembedded-core/tree/yoe/mut
and in local.conf
set
GCCVERSION = "9.%"
from opensbi.
Interesting, GCC9 is pointing out something which is a bad idea to have in code. For RISC-V it shouldn't cause catastrophic problems, but will slow things down. Even then our struct should always be aligned, so this really won't cause us any issues for us.
I think we should avoid typecasting packed structs to pointers, or not pack them
For more details you can read the GCC bug report that started this: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51628
Yes I am aware of that
I'll work on a patch, I think an intermediate variable will fix it, as that way we never take an address of a packed struct. A little bit of a pain, but I don't see a much better solution.
that will be awesome
from opensbi.
Related Issues (20)
- What is the relationship between Coreboot and Opensbi HOT 2
- ld.bfd: unrecognized option --exclude-libs HOT 2
- fw_start and fw_rw_offset not aligned
- Is there any upper memory bound for initramfs or opensbi or kernel?
- Handling interrupts with multiple privileges on multiple harts in OpenSBI HOT 1
- [help] K210 serial port has no output HOT 1
- build issue - functions do not get linked HOT 1
- System freezes when setting smp value to 54 or higher with qemu-system-riscv64
- Firmware SMP boot bug HOT 3
- sbi_hsm_hart_start_finish: ERR: The hart is in invalid state [2147774600] HOT 1
- firmware base is not the value of FW_TEXT_START( but 0x80000000) HOT 1
- How to get symtab from elf?
- qemu-system-riscv64: -append only allowed with -kernel option HOT 1
- Writing drivers for Timer peripheral
- questions about OpenSBI Version 1.5 HOT 10
- opensbi failed to build HOT 2
- error: "__always_inline" redefined [-Werror] HOT 2
- Why ld is leaving a hole in memory? HOT 4
- Why do we need a while loop when processing IMSCI external interrupts? HOT 5
- understanding -PIE HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opensbi.