remix-run / remix-jokes Goto Github PK

Disclaimer: I'm still genuinely excited about Remix, but in stepping through the remix-jokes tutorial I ran into a couple acute issues that left me scratching my head. I feel pretty confident others must have encountered them too. Hoping that posting here might help shed some light.

Issue 1: Resource Routes / RSS feature:
The tutorial's implementation differs from this repo's, and AFAICT neither of them work.
https://remix-jokes.lol/jokes.rss (like my follow-along-at-home version) returns a 200 response but there are no joke <item>s, just the feed metadata ending with </ttl>. I stopped trying to debug it when I realized it wasn't just me.

Issue 2: Deployment: Prisma vs Fly.io's default .dockerignore:
The .dockerignore file noted in the tutorial and present in this repo, auto-generated by fly launch, consists of just one path to ignore: node_modules. That's pretty standard and seems reasonable. BUT. Prisma is weird, in that it relies on generating files in node_modules/prisma -- which files are not present following npm install! (This gives me the heebie-jeebies, even if the Prisma APIs are really nice.)
So in following the tutorial step-by-step, the fly deploy step fails with errors like:

Error: Cannot find module '/root/.npm/_npx/524/lib/node_modules/prisma/scripts/preinstall-entry.js'

The only way I could mitigate this problem was to edit the .dockerignore file, adding an exclusion to NOT ignore node_modules/prisma in particular:

!node_modules/prisma

... which fixed the problem.

But, how did the setup in this repo and/or noted in the tutorial's prose ever work without making this change?
Thanks in advance for any responses!

When I run the app on Mac OS (Monterey 12.0.1), I can login successfully using Chrome (version 96.0.4664.93). However, when I try to login using Safari (version 15.1), I get redirected back to /jokes.

I haven't had time to do any debugging yet, but I did notice a difference in the console when using Chrome vs. Safari.

With Chrome, I see:

POST /login?_data=routes%2Flogin 204 - - 79.879 ms
GET /jokes?_data=root 200 - - 1.112 ms
GET /jokes?_data=routes%2Fjokes%2Findex 200 - - 6.126 ms
GET /jokes?_data=routes%2Fjokes 200 - - 12.336 ms

With Safari, I see:

POST /login?_data=routes%2Flogin 204 - - 75.138 ms
GET /jokes?_data=root 200 - - 6.954 ms
GET /jokes?_data=routes%2Fjokes 200 - - 0.761 ms
GET /jokes?_data=routes%2Fjokes%2Findex 404 - - 3.253 ms

For some reason, Safari receives a 404 for the request to GET /jokes?_data=routes%2Fjokes%2Findex. Also, Safari requests that URL after /jokes?_data=routes%2Fjokes, whereas Chrome requests it before.

Not sure if this is a Remix problem or a problem with the Jokes app or an error on my part, but I thought it was worth reporting.

Seems that https://remix-jokes.lol has two <title> tags on many pages. Is it maybe that Meta always just adds new metadata and does not overwrite parent metadata?

Using the back and forth button while being logged in. I get this: