Add functionality to dispatch Route without change real URL about react-router HOT 5 CLOSED

The usual way to do this on the web is to redirect to /auth/signin?continue=/secret or similar.

from react-router.

Interesting use case. I think I agree, the sign in step is a workflow within the secret app state.

I wonder if this is the routers job, or if I should just have a signin component that "secret" uses and my signin route uses it too.

Sent from my iPhone

On Jul 8, 2014, at 3:41 AM, Aliaksei [email protected] wrote:

It would be nice to have functionality (in transition and Router itself) to dispatch specific route without change real URL.

E.g. I have auth flow close to https://github.com/rpflorence/react-nested-router/tree/master/examples/auth-flow . I visit my auth-only page /secret. Then I must be redirected to my auth page and URL in my address bar is /auth/signin. But it would be better for user still see /secret as URL and have some auth Route as activeRoute. In such case if I press Refresh I still have /secret URL and can return to it after sign in. Now I have /auth/signin and can't it.

I see it as something like

// inside my AuthMixin
willTransitionTo: function(transition) {
//...
if (!loggedIn) {
transition.abort();
authService.setTransition(transition);
transition.forward('/auth/signin')
}
}
—
Reply to this email directly or view it on GitHub.

from react-router.

I agree with @spicyj. The URL should dictate the UI that's on the page, namely /auth/signin. Where to go after that shouldn't be part of the URL, but should instead be part of the query string. Then, after signin you can:

Router.transitionTo(this.props.query.continue || 'home');

from react-router.

I think my comments were ambiguous.

1. URLs should always have meaning, they represent application states.
2. We should not allow transitioning to a route w/o changing the URL.
3. You don't need to save the next url into the url, you can just have "signin" be a workflow within a route, reusing a SigninForm component within an AuthenticatedMixin as well as the signin route handler.

from react-router.

I suppose you're right. I've investigated some of client and server side frameworks and found that it should not be concern of routing to replace one response with another. I'd like to close this issue.

from react-router.