Git Product home page Git Product logo

Comments (6)

mjackson avatar mjackson commented on March 28, 2024

By design, all route handler descriptors are created inside the top-level route's render method. This lets the top-level route reference component instances easily when running willTransitionFrom hooks because it can reference them using this.refs.

What do you need the context for? I've seen it used in various places, but as you say the API is experimental so I'm not sure we need to support it.

from react-router.

luigy avatar luigy commented on March 28, 2024

Whoops, I didn't account for willTransition* hooks.

My only use for context is not having to pass down explicitly my flux instance into my sub routes vs only once at the root route.

<Route handler={FluxApp} flux={flux}>
  <Route name="dashboard" handler={Dashboard} flux={flux} />
  <Route name="form" handler={Form} flux={flux} />
</Route>

vs

<Route handler={FluxApp} flux={flux}>
  <Route name="dashboard" handler={Dashboard} />
  <Route name="form" handler={Form} />
</Route>

I'm using fluxxor and currently FluxChildMixin only checks for this.context, but I am just going make my own mixin.

getFlux: function() {
  return this.props.flux || this.context.flux;
}

Closing this and hopefully React on their next release enables passing down the context without having to create the child at the parent component being rendered.

from react-router.

ryanflorence avatar ryanflorence commented on March 28, 2024

I've been toying with the idea of having a RouteMixin and our Route is simply the mixin implemented into a class.

This way you could make your own route:

var FluxRoute = React.createClass({
  mixins: [RouteMixin],

  getInitialProps: function() {
    return { flux: flux };
  }
});

Then you don't have to pass it to anything:

<FluxRoute handler={App}>
  <FluxRoute path="foo" handler={Foo}/>
</FluxRoute>

Seems useful?

from react-router.

nelix avatar nelix commented on March 28, 2024

RouteMixin does seem useful

from react-router.

luigy avatar luigy commented on March 28, 2024

I got to tinker with RouteMixin in a fork... I like it 👍 ... I prefer it over messing with context till it stabilizes

from react-router.

derekdowling avatar derekdowling commented on March 28, 2024

What ever happened with this?

from react-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.