Comments (7)
The current boundary between sync and async lands is at Route#dispatch
(in the route-component branch). Routes use this method to update their state when the URL changes. It's nice to keep this boundary at a low level so it doesn't permeate the rest of the API. For example, the URLStore
would need to know about promises in order to make Router.transitionTo
return a promise.
Anyway, the best we could do would be to return a promise that resolves immediately after the call to route.setState
, which doesn't necessarily mean that changes have been made to the DOM.
Would it be too much hassle to ask people to use componentDidMount
and/or componentDidUpdate
in their tests? If people absolutely need to know when a transition
is completed, maybe we could provide a didTransitionTo
transition hook?
from react-router.
When integration testing you'll need to know exactly when you can start asserting the screen has the data you expect.
from react-router.
Right. Seems like that's exactly what componentDidUpdate
is for.
from react-router.
depending on the app's architecture, couldn't componentDidUpdate fire multiple times before a single 'transition' is over?
from react-router.
For integration tests we will need some sort of hooks to know that transitions and when data from #57 have landed before making assertions.
We should have some test helpers for this.
from react-router.
The hook you're looking for is Route#dispatch
. That method returns a promise that resolves when the transition is complete and the ActiveStore
has been updated.
from react-router.
closing for a different converstaion
from react-router.
Related Issues (20)
- [Bug]: v3 incompatibility with React 18 and StrictMode HOT 1
- [Bug]: `<Navigate to=...` breaks after `6.14.2` HOT 2
- [Bug]: useBlocker is not working HOT 5
- [Bug]: Cannot navigate in windows production HOT 2
- [Bug]: Unable to Pass State Using useNavigate When Navigating Back to Previous Route HOT 1
- [Bug]: Navigation don't work with createBrowserRouter sometimes HOT 2
- [Bug]: lazy loaded module error in nested router is catched only by the parent route with the * wildcard, not by the `errorElement` in the nested router HOT 2
- [Bug]: `fetcher.data` is define when submitting via `fetcher.submit` but is undefined when submitting a `fetcher.Form` HOT 3
- [Bug]: Navigation from '//' pathname does not work; path '*' is not matching the '//' page HOT 1
- [Bug]: Getting "A router only supports one blocker at a time" warning when running your navigation-blocking example HOT 1
- [Bug]: `setSearchParams` do not provide the latest queryString passed as argument to `navigate` HOT 3
- [Bug]: React Router swallows render error HOT 1
- [Bug]: useBlocker in createBrowserRouter is not working
- [Bug]: useLocation value being null when 0 is set as the state value of useNavigate
- [Docs]: for useSearchParams, functional updates should be explained in more detail HOT 3
- [Bug]: React router doesn't handle 'content://' URLs
- [Bug]: the state is not destroyed in the useFetcher hook with key parametr
- [Bug]: Outlet component remounts in production when changing state above it HOT 2
- [Bug]: loader of Route running even if Route / Router is not rendered HOT 1
- [Docs]: Docs for shouldRevalidate make it sound like it is only for opting out
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-router.