Git Product home page Git Product logo

Comments (4)

mjackson avatar mjackson commented on March 29, 2024

I believe the best and simplest solution to this issue would be to use window.history.back() in the piece of code that handles cancelled transitions. This would effectively change the URL back to whatever it was before the transition started, and it would preserve the ability to manually enter a new URL into the location bar (as opposed to requiring all URL changes to go through transitionTo, for example).

In this solution, the router that aborted the transition should remain unaffected by the URL change because it would never actually update its components properties. The problem with this approach would be with other routers on the same page that are also observing the URL. They would effectively see two changes to the URL in quick succession, which would probably cause some weirdness.

The best way to solve this would be to use a dispatcher singleton that is responsible for listening to the URL and dispatching transition objects to routers that need to know about URL changes. When the URL changes, it would dispatch a new Transition and wait for all transition hooks to resolve before actually telling routers to proceed with the transition and update their components.

from react-router.

mjackson avatar mjackson commented on March 29, 2024

The "transitions" example code runs fine with this commit.

from react-router.

mjackson avatar mjackson commented on March 29, 2024

It's actually one better than Ember's router because the URL is always kept in sync with what is on the page, even when it is manually changed but the transition is aborted.

from react-router.

ryanflorence avatar ryanflorence commented on March 29, 2024

:fistpump:

On Wed, Jun 11, 2014 at 9:34 AM, Michael Jackson [email protected]
wrote:

It's actually one better than Ember's router because the URL is always
kept in sync with what is on the page, even when it is manually changed but
the transition is aborted.


Reply to this email directly or view it on GitHub
#22 (comment)
.

from react-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.