Comments (16)
i def think Windows setup is something that should be part of the docs for contributors. too easy for devs to just assume everyone has macs
from reactjs.org.
i def think Windows setup is something that should be part of the docs for contributors. too easy for devs to just assume everyone has macs
There were no such assumptions. I just have a Mac myself and I wrote the docs so...I wrote what I know. We certainly welcome contributions to the contributing docs to improve the instructions for Windows users! β€οΈ
If you'd be willing to commit the changes you needed to make via a PR, @dance2die, and tag me on it- I'd be happy to merge it.
from reactjs.org.
This issue is all yours! π
I've added an "in-progress" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.
Cheers!
from reactjs.org.
Thank you @bvaughn
I will add a tag you and add the link to your comment in PR comment.
from reactjs.org.
@dance2die Your write-up says:
Now install following two NPM packages globally.
yarn global add prettier yarn global add flow-bin
Why is this necessary? Both prettier
and flow-bin
are declared as project dependencies in package.json
and so should be installed within the project.
Also, you should be able to update the "Problem2" section now since your PR has been merged. (Thanks!)
from reactjs.org.
I will work on this issue.
from reactjs.org.
Thank you @bvaughn
Struggling to set up the environment but it's part of the fun~
from reactjs.org.
Please feel free to leave feedback about where you struggled in case it helps us improve the contributing docs.
from reactjs.org.
I will create an issue and work on it later on (regarding node-gyp
failing to build on Windows)
from reactjs.org.
Hi @bvaughn Below is the feedback π with struggles I had today.
I was finally able to get it up and running but had a lot of trouble on Windows.
Below are the steps required to get the environment running on Windows 10.
- Get
node-gyp
working using this documentation on nodejs/node-gyp. - Installed following commands globally
yarn global add prettier
yarn global add flow-bin
yarn check-all
fails to execute on windows.
So I had to run each command separately one by one.
prettier --config .prettierrc --write "{flow-typed,plugins,src}/**/*.js"
yarn lint
yarn flow
yarn check-all
failed because of the single quotes used in the prettier command.
Instead of
prettier --config .prettierrc --write '{flow-typed,plugins,src}/**/*.js'
I had used double quotes around {flow-typed,plugins,src}/**/*.js
prettier --config .prettierrc --write "{flow-typed,plugins,src}/**/*.js"
from reactjs.org.
Closed via #89
from reactjs.org.
I've created a detailed blog entry on how to setup the environment on Windows 10.
https://www.slightedgecoder.com/2017/10/15/setting-reactjs-org-environment-open-source-contribution/
from reactjs.org.
Now install following two NPM packages globally.
Why is this necessary?
You are right. I just tried it after globally removing prettier
& flow-bin
.
Both commands were not found for some reason on computer at home but works fine on different machine.
Thank you, Brian. I will update the blog~
from reactjs.org.
Sweet! Ping me once it's updated and I'll tweet a link to it.
from reactjs.org.
@bvaughn
Thank you, Brian.
I've updated the blog and renamed Problem 2 -...
to "Verify that the site works".
from reactjs.org.
Cool. Thanks!
from reactjs.org.
Related Issues (20)
- Left-Scroll-Bar[Bug]: HOT 3
- [Typo]: `<style>` syntax looks wrong HOT 1
- [Bug]: Challenges section not connecting to sandbox HOT 3
- [Bug]: Invalid Hook call HOT 1
- .
- [Suggestion]: Add a search page (not just a modal) HOT 1
- [Mistake]: One of the examples in the docs is performing side effect in render? HOT 2
- [Bug]: Can not access the react.dev website HOT 11
- [Bug]: Issue with Sandpacks HOT 7
- Add language switcher to the design in react.dev
- [Suggestion]: Add example for retry with the `use` hook and an error boundary
- [Suggestion]: How to use local language search on a translation website
- [Suggestion]: Clarification on react.cache Usage in Server Requests
- [Typo]: Possible incorrect info HOT 1
- [Suggestion]: Add a new page for how to communicate between components. HOT 4
- [Suggestion]: "falsy" values not in the new documentation HOT 2
- [Bug]: sidepanel is blocking main content HOT 3
- [Suggestion]: Change the error message "Objects are not valid as a React child (found: object with keys {aaa, bbb}). If you meant to render a collection of children, use an array instead.
- [Mistake]: getVisibleTodos() does not re-run (and does not print any logs) when you type into the input to begin with! HOT 2
- δΈζζζ‘£ε·²η»uiεε½’δΊ HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reactjs.org.