Git Product home page Git Product logo

Comments (16)

swyxio avatar swyxio commented on March 29, 2024 2

i def think Windows setup is something that should be part of the docs for contributors. too easy for devs to just assume everyone has macs

from reactjs.org.

bvaughn avatar bvaughn commented on March 29, 2024 2

i def think Windows setup is something that should be part of the docs for contributors. too easy for devs to just assume everyone has macs

There were no such assumptions. I just have a Mac myself and I wrote the docs so...I wrote what I know. We certainly welcome contributions to the contributing docs to improve the instructions for Windows users! ❀️

If you'd be willing to commit the changes you needed to make via a PR, @dance2die, and tag me on it- I'd be happy to merge it.

from reactjs.org.

bvaughn avatar bvaughn commented on March 29, 2024 1

This issue is all yours! πŸ˜„

I've added an "in-progress" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

Cheers!

from reactjs.org.

dance2die avatar dance2die commented on March 29, 2024 1

Thank you @bvaughn
I will add a tag you and add the link to your comment in PR comment.

from reactjs.org.

bvaughn avatar bvaughn commented on March 29, 2024 1

@dance2die Your write-up says:

Now install following two NPM packages globally.

yarn global add prettier
yarn global add flow-bin

Why is this necessary? Both prettier and flow-bin are declared as project dependencies in package.json and so should be installed within the project.

Also, you should be able to update the "Problem2" section now since your PR has been merged. (Thanks!)

from reactjs.org.

dance2die avatar dance2die commented on March 29, 2024

I will work on this issue.

from reactjs.org.

dance2die avatar dance2die commented on March 29, 2024

Thank you @bvaughn
Struggling to set up the environment but it's part of the fun~

from reactjs.org.

bvaughn avatar bvaughn commented on March 29, 2024

Please feel free to leave feedback about where you struggled in case it helps us improve the contributing docs.

from reactjs.org.

dance2die avatar dance2die commented on March 29, 2024

I will create an issue and work on it later on (regarding node-gyp failing to build on Windows)

from reactjs.org.

dance2die avatar dance2die commented on March 29, 2024

Hi @bvaughn Below is the feedback πŸ‘ with struggles I had today.

I was finally able to get it up and running but had a lot of trouble on Windows.

Below are the steps required to get the environment running on Windows 10.

  1. Get node-gyp working using this documentation on nodejs/node-gyp.
  2. Installed following commands globally
yarn global add prettier
yarn global add flow-bin
  1. yarn check-all fails to execute on windows.

image

So I had to run each command separately one by one.

prettier --config .prettierrc --write "{flow-typed,plugins,src}/**/*.js"
yarn lint
yarn flow

yarn check-all failed because of the single quotes used in the prettier command.
Instead of
prettier --config .prettierrc --write '{flow-typed,plugins,src}/**/*.js'
I had used double quotes around {flow-typed,plugins,src}/**/*.js
prettier --config .prettierrc --write "{flow-typed,plugins,src}/**/*.js"

from reactjs.org.

bvaughn avatar bvaughn commented on March 29, 2024

Closed via #89

from reactjs.org.

dance2die avatar dance2die commented on March 29, 2024

I've created a detailed blog entry on how to setup the environment on Windows 10.
https://www.slightedgecoder.com/2017/10/15/setting-reactjs-org-environment-open-source-contribution/

from reactjs.org.

dance2die avatar dance2die commented on March 29, 2024

@bvaughn

Now install following two NPM packages globally.

Why is this necessary?

You are right. I just tried it after globally removing prettier & flow-bin.
Both commands were not found for some reason on computer at home but works fine on different machine.

Thank you, Brian. I will update the blog~

from reactjs.org.

bvaughn avatar bvaughn commented on March 29, 2024

Sweet! Ping me once it's updated and I'll tweet a link to it.

from reactjs.org.

dance2die avatar dance2die commented on March 29, 2024

@bvaughn
Thank you, Brian.

I've updated the blog and renamed Problem 2 -... to "Verify that the site works".

from reactjs.org.

bvaughn avatar bvaughn commented on March 29, 2024

Cool. Thanks!

from reactjs.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.