Git Product home page Git Product logo

Comments (4)

aaronjudd avatar aaronjudd commented on April 20, 2024

See https://github.com/ongoworks/reaction-core/commit/9a19bfdf2e79

from reaction.

aaronjudd avatar aaronjudd commented on April 20, 2024

@aldeed your change just shows the existing "placeholder" image when uploading correct? Should we make this an actual progress bar?

from reaction.

aldeed avatar aldeed commented on April 20, 2024

Yep, I just did a quick fix so that things didn't jerk around on the screen. I think ideally I'd prefer a box the same size as the eventual image, but with a circular/piechart progress indicator in the middle. First it would show "Uploading..." with circular progress and then switch to "Storing..." with circular progress. Another option that we have been wanting to add to CFS is instant client-side preview during upload/storage. You might even want the client-side preview image shown but with the progress indicators overlaid until the real file is shown.

All of these ideas could actually be implemented in the cfs-ui package or other CFS packages, and then just used here.

from reaction.

aaronjudd avatar aaronjudd commented on April 20, 2024

Closing, existing progress bar works in image gallery. @mikemurray @kieckhafer will review again when we next update image gallery.

from reaction.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.