[Bug][7.1+] Development of "Add validation option for enum" is incomplete about rails HOT 3 CLOSED

Ok, I see that is already implemented in #50333

from rails.

validate: ... is an implemented syntax, not a _validate: .... Why do you expect it to work?

from rails.

validate: ... is an implemented syntax, not a _validate: .... Why do you expect it to work?

Hi,

This is just how enums are built.

You can do the following:

enum :my_enum, [:value, :value2], prefix: true, suffix: false, instance_methods: false, validate: true

enum another_enum2: { value: "something" }, _prefix: true, _suffix: false, _instance_methods: false

But in the second instance you can't do the following: _validate: true

It simply appears to have been forgotten, don't you agree?

By looking at the implementation, it seems we can declare many enums at once:

enum enum1: { value: "something" }, enum2: { hello: "world" }, _prefix: true

So because _validate: true isn't explicitly in the slice!(...)ActiveRecord thinks it's another enum to define.

Edit: To those interested, this initializer fix the behavior in the mean time

module ValidatableEnum
  extend ActiveSupport::Concern

  included do
    def self.enum(name = nil, values = nil, **options)
      return super if name

      definitions = options.slice!(:_prefix, :_suffix, :_scopes, :_default, :_instance_methods, :_validate)
      options.transform_keys! { |key| :"#{key[1..]}" }

      definitions.each { |name, values| _enum(name, values, **options) }
    end
  end
end

ActiveSupport.on_load(:active_record) { include ValidatableEnum }

from rails.