feature: Run.add_picture() about python-docx HOT 3 CLOSED

I would. Needs to have tests though. The ones for Run.add_break() should be good models:

• acceptance test for add_break() (one scenario should be enough)
• The steps for the add_break() acceptance test should be very similar, I think it's just three or four of those.
• This single unit test for add_break() should be a good model, along with its fixture further down in the file. It might not need any parameters. Break did because there are several different types of break.

Let me know if you need help getting started with the testing. I've been meaning to document it better, just haven't gotten to it yet.

Pull needs to be on a distinct new branch on your fork. feature/run-add-picture let's say. You should expect that you'll need to make adjustments based on feedback to your initial pull request. Once or twice should do it :) Those changes should be in the same commits so you should be familiar with rebasing. The acceptance test should be in the first commit, by itself. Then one commit for each test/code pair. Maybe only one of those for this, we'll have to see how it goes :)

Interface should model docx.api.Document.add_picture(), i.e. image descriptor can be path or file-like object and dimensions can be specified, defaulted, or scaled on width or height. You should be able to get that from add_picture() by copy and paste. Shame on me for not factoring that bit out into a separate method somewhere, I'll clean that up later.

Let me know if you have any questions on the specifics :)

from python-docx.

Analysis notes

Need access to the part in order to create the relationship to the image part. This implies that Run, Paragraph, Body, Table, Row, Col, and Cell all need Parented as a base class.

from python-docx.

feature Run.add_picture() added in release 0.7.1 today.

from python-docx.